[GRASS-QA] GRASS QA: martinl | ./grass6/raster/r.to.vect/areas.c |2
clones ( curses.c graphics.c mouse.c signature.c plot.c
main.c main.c main.c main.c main.c main.c graphics.c
graphics.c graphics.c graphics.c graphics.c c_update.c
d_drop_index.c d_drop_tab.c list.c raster_rgb.c raster_rgb.c
raster_rgb.c raster_rgb.c Get_location.c com_proto.c
com_proto.c com_proto.c loc_proto.c loc_proto.c loc_proto.c
i_face.c main.c main.c level_two.c main.c build.c line.c
read_nat.c areas.c )| 0 monsters | 0 warnings
grass-qa at proxy.soccerlab.polymtl.ca
grass-qa at proxy.soccerlab.polymtl.ca
Thu Mar 1 19:38:36 EST 2007
Hello martinl,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
raster/r.to.vect/areas.c functions
extract_areas (Begins at: 108 Ends at: 154)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 22 | | OK |
LOC: | 47 | | OK |
--------------+---------+-------+---------+
metrics are OK
update_list (Begins at: 162 Ends at: 322)
--------------+---------+-------+---------+
Complexity: | 12 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 33 | | OK |
LOC: | 161 | * | |
--------------+---------+-------+---------+
metrics are OK
end_vline (Begins at: 327 Ends at: 335)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 9 | | OK |
--------------+---------+-------+---------+
metrics are OK
end_hline (Begins at: 337 Ends at: 345)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 9 | | OK |
--------------+---------+-------+---------+
metrics are OK
start_vline (Begins at: 350 Ends at: 362)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
start_hline (Begins at: 364 Ends at: 376)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 13 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_ptr (Begins at: 380 Ends at: 417)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 38 | | OK |
--------------+---------+-------+---------+
metrics are OK
nabors (Begins at: 419 Ends at: 485)
--------------+---------+-------+---------+
Complexity: | 12 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 67 | | OK |
--------------+---------+-------+---------+
metrics are OK
read_next (Begins at: 489 Ends at: 498)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
metrics are OK
alloc_areas_bufs (Begins at: 503 Ends at: 528)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 26 | | OK |
--------------+---------+-------+---------+
metrics are OK
equiv_areas (Begins at: 533 Ends at: 600)
--------------+---------+-------+---------+
Complexity: | 12 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 7 | | OK |
LOC: | 68 | | OK |
--------------+---------+-------+---------+
metrics are OK
map_area (Begins at: 602 Ends at: 631)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 30 | | OK |
--------------+---------+-------+---------+
metrics are OK
add_to_list (Begins at: 635 Ends at: 668)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 34 | | OK |
--------------+---------+-------+---------+
metrics are OK
assign_area (Begins at: 673 Ends at: 686)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
more_areas (Begins at: 690 Ends at: 705)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 16 | | OK |
--------------+---------+-------+---------+
metrics are OK
more_equivs (Begins at: 709 Ends at: 724)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 16 | | OK |
--------------+---------+-------+---------+
metrics are OK
update_width (Begins at: 727 Ends at: 754)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 28 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file has 2 potentially cloned functions:
more_equivs more_areas
In raster/r.to.vect/areas.c clones of more_areas are:
raster/r.to.vect/areas.c more_equivs
In raster/r.to.vect/areas.c clones of more_equivs are:
raster/r.to.vect/areas.c more_areas
__________________________________________
Threshold GRASS6 key metrics values at 2007-03-01 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 8 |
CalledNBR: 10 | 60 | 86 |
LOC: 42 | 190 | 265 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list