[GRASS-QA] GRASS QA: martinl | ./grass6/lib/vector/diglib/plus.c |3 clones ( plus.c )| 0 monsters | 0 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello martinl,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/vector/diglib/plus.c functions


dig_init_plus (Begins at: 49 Ends at: 123)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      75 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

dig_free_plus_nodes (Begins at: 126 Ends at: 157)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       5 |       |      OK |
LOC:          |      32 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

dig_free_plus_lines (Begins at: 160 Ends at: 195)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      36 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

dig_free_plus_areas (Begins at: 198 Ends at: 231)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       5 |       |      OK |
LOC:          |      34 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

dig_free_plus_isles (Begins at: 234 Ends at: 267)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      34 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

dig_free_plus (Begins at: 270 Ends at: 291)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      22 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

dig_load_plus (Begins at: 294 Ends at: 372)
--------------+---------+-------+---------+
Complexity:   |      11 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      32 |       |      OK |
LOC:          |      79 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

dig_write_plus_file (Begins at: 375 Ends at: 432)
--------------+---------+-------+---------+
Complexity:   |       7 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      16 |       |      OK |
LOC:          |      58 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

dig_write_nodes (Begins at: 435 Ends at: 461)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      27 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

dig_write_lines (Begins at: 464 Ends at: 491)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      28 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

dig_write_areas (Begins at: 494 Ends at: 521)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      28 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

dig_write_isles (Begins at: 524 Ends at: 540)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      17 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 3 potentially cloned functions:
  dig_write_isles  dig_write_areas  dig_write_lines

In lib/vector/diglib/plus.c clones of  dig_write_isles are:
	lib/vector/diglib/plus.c  dig_write_areas
	lib/vector/diglib/plus.c  dig_write_lines

In lib/vector/diglib/plus.c clones of  dig_write_lines are:
	lib/vector/diglib/plus.c  dig_write_isles
	lib/vector/diglib/plus.c  dig_write_areas

In lib/vector/diglib/plus.c clones of  dig_write_areas are:
	lib/vector/diglib/plus.c  dig_write_isles
	lib/vector/diglib/plus.c  dig_write_lines


__________________________________________

Threshold GRASS6 key metrics values at 2007-03-06 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:              10 |        60 |      86 |
LOC:                    42 |       190 |     265 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html