[mapguide-internals] Bug in Beta1

Fri May 4 17:08:34 EDT 2007

After MGOS 1.2 ships I suggest we create a couple new macros to
safeguard future issues. Ie:

MG_DEBUG - this could wrap the ACE_DEBUG calls for us.
MG_ASSERT - Replace the existing asserts that are causing some grief.

I'm sure there are more, but this is a start.

Bruce

-----Original Message-----
From: mapguide-internals-bounces at lists.osgeo.org
[mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of Walt
Welton-Lair
Sent: May 4, 2007 3:00 PM
To: MapGuide Internals Mail List
Subject: RE: [mapguide-internals] Bug in Beta1

That seems like wrong behavior in ACE_DEBUG.  For release I would expect
zero code to be generated.

Maybe it's documented to work that way though for debug and release.  (I
remember .NETs Debug.Output method behaving similarly.)  If that's the
case we might want to consider using something else to output debug
information, rather than having to wrap all these calls with #ifdefs.

Steve - thanks for tracking this down and offering to fix it.

Walt

-----Original Message----- 
From: mapguide-internals-bounces at lists.osgeo.org on behalf of Steve Dang

Sent: Fri 5/4/2007 10:44 PM 
To: MapGuide Internals Mail List 
Cc: 
Subject: RE: [mapguide-internals] Bug in Beta1

	I remember the issue now. With ACE_DEBUG statements, the web
tier
	outputs information to STD OUT under both debug and release. So,
we need
	to wrap ACE_DEBUG calls around with #ifdef _DEBUG's. I will fix
this.

	Steve.

	-----Original Message-----
	From: mapguide-internals-bounces at lists.osgeo.org
	[mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of
Steve
	Dang
	Sent: Friday, May 04, 2007 2:14 PM
	To: MapGuide Internals Mail List
	Subject: RE: [mapguide-internals] Bug in Beta1

	We normally use ACE_DEBUG in the Server code only, not in the
Web Tier
	or Common. Does anyone recall if there is some issue with
ACE_DEBUG in
	the Web Tier?

	Steve.

	-----Original Message-----
	From: mapguide-internals-bounces at lists.osgeo.org
	[mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of
Bruce
	Dechant
	Sent: Friday, May 04, 2007 2:06 PM
	To: MapGuide Internals Mail List
	Subject: RE: [mapguide-internals] Bug in Beta1

	The calls are helpful when running a debug server. They do not
appear
	when a release build is done. We should not get rid of them.

	If these were appearing then somehow a debug DLL was included in
the
	installer.

	Bruce

	-----Original Message-----
	From: mapguide-internals-bounces at lists.osgeo.org
	[mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of
Steve
	Dang
	Sent: May 4, 2007 2:03 PM
	To: MapGuide Internals Mail List
	Subject: RE: [mapguide-internals] Bug in Beta1

	And also this:

	    ACE_DEBUG((LM_DEBUG, ACE_TEXT( "(%P|%t)
	MgSiteManager::Initialize()\n")));

	This class is commonly used by both the Server and Web Tier, so
we may
	want to get rid of these ACE_DEBUG calls.

	Steve.

	-----Original Message-----
	From: mapguide-internals-bounces at lists.osgeo.org
	[mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of
Bruce
	Dechant
	Sent: Friday, May 04, 2007 1:53 PM
	To: MapGuide Internals Mail List
	Subject: RE: [mapguide-internals] Bug in Beta1

	This only appears if a debug build is being used.

	This is the code piece that displays what you are seeing:

	ACE_DEBUG((LM_DEBUG, ACE_TEXT("(%P|%t)
	MgSiteManager::~MgSiteManager()\n")));

	Thanks,
	Bruce

	-----Original Message-----
	From: mapguide-internals-bounces at lists.osgeo.org
	[mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of
Walt
	Welton-Lair
	Sent: May 4, 2007 12:03 PM
	To: MapGuide Internals Mail List
	Subject: RE: [mapguide-internals] Bug in Beta1

	Don't enter a ticket.  I'll scan the code real quick tonight,
and if I
	see the problem I'll add a ticket and fix it.

	        -----Original Message-----
	        From: mapguide-internals-bounces at lists.osgeo.org on
behalf of
	Jason Birch
	        Sent: Fri 5/4/2007 8:00 PM
	        To: MapGuide Internals Mail List
	        Cc:
	        Subject: RE: [mapguide-internals] Bug in Beta1

	        Ok, after a clean re-install it's not happening.

	        Should I file a bug anyway?  It seems like this
shouldn't be
	getting
	        sent to PHP output under normal operations, even if
error
	reporting is
	        turned on...

	        Jason

	        -----Original Message-----
	        From: mapguide-internals-bounces at lists.osgeo.org
	        [mailto:mapguide-internals-bounces at lists.osgeo.org] On
Behalf Of
	Jason
	        Birch
	        Sent: Friday, May 04, 2007 10:21
	        To: MapGuide Internals Mail List
	        Subject: RE: [mapguide-internals] Bug in Beta1

	        Weird.  Still doing it in Beta 2 on that server.

	        Maybe it's a setting in my PHP.ini, an old file from my
upgrade,
	or an
	        artifact of running on IIS.  I'm going to try a clean
install
	and see if
	        it goes away.

	        J

	        -----Original Message-----
	        From: Jason Birch
	        Subject: [mapguide-internals] Bug in Beta1

	        ... it appears to have been fixed in Beta2, but though
I'd send
	a note
	        anyway.
	        _______________________________________________
	        mapguide-internals mailing list
	        mapguide-internals at lists.osgeo.org

http://lists.osgeo.org/mailman/listinfo/mapguide-internals
	        _______________________________________________
	        mapguide-internals mailing list
	        mapguide-internals at lists.osgeo.org

http://lists.osgeo.org/mailman/listinfo/mapguide-internals

	_______________________________________________
	mapguide-internals mailing list
	mapguide-internals at lists.osgeo.org
	http://lists.osgeo.org/mailman/listinfo/mapguide-internals

	_______________________________________________
	mapguide-internals mailing list
	mapguide-internals at lists.osgeo.org
	http://lists.osgeo.org/mailman/listinfo/mapguide-internals

	_______________________________________________
	mapguide-internals mailing list
	mapguide-internals at lists.osgeo.org
	http://lists.osgeo.org/mailman/listinfo/mapguide-internals

	_______________________________________________
	mapguide-internals mailing list
	mapguide-internals at lists.osgeo.org
	http://lists.osgeo.org/mailman/listinfo/mapguide-internals

	_______________________________________________
	mapguide-internals mailing list
	mapguide-internals at lists.osgeo.org
	http://lists.osgeo.org/mailman/listinfo/mapguide-internals