PostGIS Connector Bug 1536 Fix

[Tamas Szekeres]

Jerry,

I guess you are referring to
http://mapserver.gis.umn.edu/bugs/show_bug.cgi?id=1536

I'm not so far with how the fix was made actually, but i'm a bit
uncertain whether
http://mapserver.gis.umn.edu/bugs/show_bug.cgi?id=1549
was also handled.

How should we quote the names in the map file properly?

Best Regards,

Tamas


2006/8/17, Jerry Pisk <jerry.pisk at gmail.com>:
> Hello,
>
> since I haven't heard from anyone I was wondering if it would be
> feasible to roll back the changes made for this bug - quoting column
> names in PostGIS queries. The way the fix was implemented it broke map
> files that use expressions in their queries or in attributes such as
> FILTERITEM or LABELITEM.
>
> The correct way to handle this is to flag columns that came from the
> PostGIS connector itself (it executes a select * from query to
> populate layer items collection) and only quote those names. Names
> coming from the map file should be the responsibility of the user. The
> problem is that this would require an additional array marking which
> layer "items" came from the map file and which came from the PostGIS
> connector (in msPOSTGISLayerGetItems). I can only assume Oracle
> Spatial connector is going to have the same issue.
>
> Another solution would be to explicitly prohibit expressions in layer "items".
>
> I would like to know what others think before I start any work this.
> For now I have just branched mapserver to suit my needs which is not
> exactly the ideal solution.
>
> Jerry Pisk
>