RFC-24 for symbolObjs is done

Umberto Nicoletti umberto.nicoletti at GMAIL.COM
Tue Jul 17 02:45:34 EDT 2007


Thanks Frank!
Does this also fix the problem mentioned by Assefa?

I usually run the msautotest suite before cvs commits and I did not
notice segfaults...maybe they scrolled past the screen along with
other failures.

We should probably detect and differentiate segfaults in the
msautotest suite from generic failures to make sure they dont' go
unseen. I'll open a ticket to remind us of this.

I'll run the msautotest suite right now to make sure it is all okay.

Thanks to all,
Umberto

On 7/17/07, Frank Warmerdam <warmerdam at pobox.com> wrote:
> Umberto Nicoletti wrote:
> > As I promised last friday I have worked on symbolObjs to implement
> > rfc-24 and now the code is in svn (rev. 6308).
> >
> > The code compiles cleanly (including mapscript and php), is memory
> > leaks free (tested with valgrind) and runs the msautotest suite
> > without errors (segfaults, that is).
> > I have, as usual for RFC-24, added new tests to the refcount.py python
> > test tuite.
> >
> > I still have to update the rfc page, I'll do that later.
>
> Umberto,
>
> I've made a few fixes in mapsymbol.c with failing to allocate
> symbols in msAddImageSymbol() and msAddNewSymbol() in mapsymbol.c:
>
>    http://trac.osgeo.org/mapserver/changeset/6318
>
> These were brought out by the msautotest/misc tests which demonstrated
> a crash.  It highlights our need for additional regression testing
> for symbol services which is very thin right now.
>
> Best regards,
> --
> ---------------------------------------+--------------------------------------
> I set the clouds in motion - turn up   | Frank Warmerdam, warmerdam at pobox.com
> light and sound - activate the windows | http://pobox.com/~warmerdam
> and watch the world go round - Rush    | President OSGeo, http://osgeo.org
>
>



More information about the mapserver-dev mailing list