[mapserver-dev] MS RFC 133: Mapfile Syntax Cleanup

Tue Mar 30 14:30:08 PDT 2021

Also +1

Mike

From: mapserver-dev <mapserver-dev-bounces at lists.osgeo.org> on behalf of Even Rouault <even.rouault at spatialys.com>
Date: Tuesday, March 30, 2021 at 5:02 PM
To: Seth G <sethg at geographika.co.uk>, Steve Lime <sdlime at gmail.com>
Cc: MapServer Dev Mailing List <mapserver-dev at lists.osgeo.org>
Subject: Re: [mapserver-dev] MS RFC 133: Mapfile Syntax Cleanup

I'm +1 on the RFC

Even

Le 30/03/2021 à 22:57, Seth G a écrit :

Hi Steve,

I'm not sure where I got CLASS MAXSCALE from - it is not a property of the classObj or referenced anywhere in the sourcecode/tests. I'll remove from the RFC. 

Anyone else on the PSC  more votes on this?

I'm tempted to merge https://github.com/MapServer/MapServer/pull/6264/ (this is mainly Steve's work, and then I updated the msautotests), it touches a lot of files so may need to be rebased quite often if not merged soon.

Seth

--

web:http://geographika.co.uk

twitter: @geographika

On Mon, Mar 29, 2021, at 4:54 PM, Steve Lime wrote:

Hi Seth: In general I'm a strong +1 on this, anything that simplifies the code base is a good thing.. Only one I wonder about is CLASS MAXSCALE since MINSCALE is currently supported as well? Personally I'm selfish and I really like the MINSCALE/MAXSCALE aliases so retaining those across the board would save me a ton of work when 8.0 arrives.

--Steve

On Tue, Mar 16, 2021 at 6:08 PM Seth G <sethg at geographika.co.uk> wrote:

Hi all,

I've made a start of implementing RFC 133 [1] by removing the now redundant LAYER DUMP keyword [2].

It would be good to get some votes in before proceeding further in case people have objections to the overall aim of removing deprecated keywords for the 8.0 release. 

Any objections to specific keywords being removed can be raised on individual pull requests. 

Seth

[1] https://mapserver.org/development/rfc/ms-rfc-133.html

[2] https://github.com/MapServer/MapServer/pull/6264

--

web:http://geographika.co.uk

twitter: @geographika

On Tue, Feb 2, 2021, at 11:18 PM, Seth G wrote:

Hi Steve,

If you could do a reference pull request I can use this as a template for the other keywords.

I guess it needs a vote before accepting, so I'll start with my +1 - removing ambiguity around keywords will help new MapServer users. I was adding the DUMP keyword to all LAYER configs for several years "just in case"...

Seth

--

web:http://geographika.co.uk

twitter: @geographika

On Tue, Feb 2, 2021, at 12:31 AM, Steve Lime wrote:

I don't recall any keyword removals specifically. Should have to touch:

maplexer.l to remove keywords from the grammar 
mapfile.c/mapfile.h to remove read/write cases and symbols
mapserver.h to remove structure members
Updating the maplexer.l effectively stops support, the rest is just cleanup. I'll commit to taking a run through all of these in the next day or so. It's a long list...

--Steve

On Fri, Jan 29, 2021 at 3:06 PM Seth G <sethg at geographika.co.uk> wrote:

Hi all,

I've got round to a draft RFC for cleaning up deprecated and legacy Mapfile keywords, based on current docs and going through all the allowed syntax as part of mappyfile development and ongoing MapScript docs updates. 

https://mapserver.org/development/rfc/ms-rfc-133.html

It might be too early to vote on the RFC without some discussion about which keywords should be removed. 

In terms of updates any keyword removal would be a separate pull request. The changes to mapfile.c seem fine (and the msautotest Mapfiles), but I've never used the lexer/parser/Bison process. Are there any sample commits when a Mapfile keyword has been removed previously?

Thoughts/comments welcome,

Seth

--

web:http://geographika.co.uk

twitter: @geographika

_______________________________________________

mapserver-dev mailing list

mapserver-dev at lists.osgeo.org

https://lists.osgeo.org/mailman/listinfo/mapserver-dev

_______________________________________________

mapserver-dev mailing list

mapserver-dev at lists.osgeo.org

https://lists.osgeo.org/mailman/listinfo/mapserver-dev

_______________________________________________
mapserver-dev mailing list
mapserver-dev at lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/mapserver-dev
-- 
http://www.spatialys.com
My software is free, but my time generally not.
_______________________________________________ mapserver-dev mailing list mapserver-dev at lists.osgeo.org https://lists.osgeo.org/mailman/listinfo/mapserver-dev 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/mapserver-dev/attachments/20210330/613e6030/attachment.html>