[OpenLayers-Dev] Questions about onFeatureInsert() and Features.state

Tim Schaub tschaub at opengeo.org
Wed Feb 25 08:12:13 EST 2009


Hey-

Niklas Ringdahl wrote:
> I am editing features in a Vector layer and discovered that there are some
> gaps in the logic in Vector.js. It turns out that Jean-Christophe posted on
> this a while ago, would it be possible to change Vector.js per his request?
> It would improve the editing flow very much. Or should I post a suggestion?
> We have been in contact with Tim Schaub on the "deleted features" matter
> mentioned below, and I think there will be a patch on that soon, but I am
> not sure about that.
> 
> I am quite new to the Open Source domain, so I am not sure of how I am
> expected to act upon a change request. Shall I post a suggested new version
> of Vector.js?

I've created a patch for one part of the issues you refer to.  You can 
see this ticket as an example of how to submit a contribution.

http://trac.openlayers.org/ticket/1953

The ticket references one specific issue and provides a patch that 
addresses the issue.  The patch for the ticket has tests.  The ticket is 
targeted for a particular milestone and marked review ("Review" state).

There is some more detail on the process of contributing on the wiki:
http://trac.openlayers.org/wiki/HowToContribute

Please make tickets for any of the other issues you've commented on here 
(or maybe you already have) - and write back with ticket numbers.

Thanks!
Tim

> 
> Best regards,
> - Niklas
> 
> 
> jc A wrote:
>> A remark about OpenLayers.Feature.Vector.state :
>>
>> In OpenLayers.Feature.Vector.initialize(..) Line ~50
>> this.state should be initialized like :
>> this.state = OpenLayers.State.UNKNOWN;
>>
>> Or, in the function toState(..) you should add a 'defaut:' at lines ~213
>> and ~234 to manage the case where : this.state is null
>>
>> ---
>>
>> And the last question :
>>
>> Is it possible today to not draw (hide) a  'deleted' feature ?
>> I mean a feature where feature.state is OpenLayers.State.DELETE ?
>>
>>
>> Regards.
>>
>> Jean-Christophe ALBERT
>>
>>
>>
>>
>>
>>
>>
>>
>>
>> 	
>>
>> 	
>> 		
>> ___________________________________________________________________________ 
>> Découvrez une nouvelle façon d'obtenir des réponses à toutes vos questions
>> ! 
>> Profitez des connaissances, des opinions et des expériences des
>> internautes sur Yahoo! Questions/Réponses 
>> http://fr.answers.yahoo.com
>> _______________________________________________
>> Dev mailing list
>> Dev at openlayers.org
>> http://openlayers.org/mailman/listinfo/dev
>>
>>
> 


-- 
Tim Schaub
OpenGeo - http://opengeo.org
Expert service straight from the developers.



More information about the Dev mailing list