[OpenLayers-Dev] Re: "allow pan while drawing" patch

[Pierre Giraud]

Actually, I think that there's at least one big difference between the
current behavior and the new one.

When drawing a line for example :
 - in the current trunk version, when user adds a point each time the
mouse button is pushed down, even if he's fast,
 - in Eric's implementation, the user has to be very precise (ie.
mousedown and mouseup have to be at the exact same location). It means
that he'll miss a lot of vertices if he want to draw quickly.

You can have a try by unchecking the "allow pan while drawing". It's
very frustrating when you think you added a vertex but actually you
didn't. It's even more frustrating when you can't tell if it happened
or not.

Maybe, a distance or time tolerance would be required.

I really like the new behavior though. I think this is a "must have
been available earlier". It's really awesome, and so helpful for
digitizing.

Pierre

On Tue, Jan 18, 2011 at 5:47 PM, Andreas Hocevar <ahocevar at opengeo.org> wrote:
> I think that this is awesome! I haven't looked at the code, but I'd say if it doesn't change any API behavior we rely on currently (like when the sketch layer is added, when events are fired), this would be a great addition to trunk, and should not live a poor life in an addin.
>
> Thanks!
> Andreas.
>
> On Jan 18, 2011, at 17:01 , Eric Lemoine wrote:
>
>> On Thu, Jan 13, 2011 at 10:32 PM, Eric Lemoine
>> <eric.lemoine at camptocamp.com> wrote:
>>> On Thursday, January 13, 2011, Tim Schaub <tschaub at opengeo.org> wrote:
>>>> I should add.  I'll be interested to hear what you think about supporting freehand and snapping together.  This is a combination of functionality that we're relying on.
>>>
>>> When drawing in freehand mode (for example with the freehand modifier
>>> key pressed) we could just dynamically make "pan while drawing"
>>> ineffective. So the freehand snapping combination would pretty much
>>> work like today.
>>
>> The examples at
>> <http://dev.openlayers.org/sandbox/elemoine/draw-feature/examples/draw-feature.html>
>> and exemplifies this.
>>
>> My patch alters the user experience - points are added on mouseup, and
>> a point is drawn on activate. Given that I'm happy to create new
>> handlers, and place them in a new addin. This addin could be used as
>> an incubation home, and inclusion into the lib could be considered
>> later, for OpenLayers 3 for example.
>>
>> Thank you for any comment,
>>
>> --
>> Eric Lemoine
>>
>> Camptocamp France SAS
>> Savoie Technolac, BP 352
>> 73377 Le Bourget du Lac, Cedex
>>
>> Tel : 00 33 4 79 44 44 96
>> Mail : eric.lemoine at camptocamp.com
>> http://www.camptocamp.com
>> _______________________________________________
>> Dev mailing list
>> Dev at lists.osgeo.org
>> http://lists.osgeo.org/mailman/listinfo/openlayers-dev
>
>
>
> --
> Andreas Hocevar
> OpenGeo - http://opengeo.org/
> Expert service straight from the developers.
>
> _______________________________________________
> Dev mailing list
> Dev at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/openlayers-dev
>



-- 
Pierre GIRAUD
Géomaticien, Analyste

Camptocamp France SAS
Savoie Technolac, BP 352
73377 Le Bourget du Lac, Cedex

Tel : 00 33 4 79 44 44 93
Mail : pierre.giraud at camptocamp.com
http://www.camptocamp.com