[OpenLayers-Dev] jshint, 'use strict' and code conventions

[Andreas Hocevar]

Hey Marc,

I think it does not make sense to use "use strict", as it catches
nothing that a good linter wouldn't catch.

I do use jshint, and these are the options I use (mostly JSLintMate
defaults I think):

  /*** Enforcing options ***/
  // Set these to `true` to enforce, or `false` to relax.
  "bitwise":      true,
  "curly":        true,
  "eqeqeq":       false,
  "forin":        false,
  "immed":        true,
  "latedef":      false,
  "newcap":       true,
  "noarg":        true,
  "noempty":      true,
  "nonew":        true,
  "plusplus":     false,
  "regexp":       false,
  "undef":        true,
  "strict":       false,
  "trailing":     true,

  /*** Relaxing options ***/
  // Set these to `true` to relax, or `false` to enforce.
  "asi":          false,
  "boss":         true,
  "debug":        false,
  "eqnull":       true,
  "es5":          true,
  "esnext":       true,
  "evil":         true,
  "expr":         true,
  "funcscope":    false,
  "globalstrict": false,
  "iterator":     false,
  "lastsemic":    false,
  "laxbreak":     false,
  "laxcomma":     false,
  "loopfunc":     true,
  "multistr":     false,
  "onecase":      false,
  "proto":        false,
  "regexdash":    false,
  "scripturl":    false,
  "shadow":       true,
  "smarttabs":    true,
  "sub":          false,
  "supernew":     false,
  "validthis":    true,

Andreas.

On Mon, Feb 18, 2013 at 9:08 AM, Marc Jansen <jansen at terrestris.de> wrote:
> Hi all,
>
> I know that we have discussed parts of this previously but wanted to bring
> the discussion back to life.
>
> In a recent PR we discussed about our policy regarding "use strict":
> https://github.com/openlayers/openlayers/pull/884#discussion_r3042108
>
> I think we should have a discussion regarding the measurable 'quality' of
> our source code.
>
> I suggest that we
>
> have a policy about dealing with "use strict"
> agree on jshinting new source code (and with what options)
>
> Once we have agreed on this I am willing to spend some time on jshinting
> existing sourcefiles, but only if  we have a common ground of agreed
> options.
>
> What do you guys think?
>
> Best regards,
> Marc
>
>
> --
>
>   Dipl.-Geogr. Marc Jansen
>   — Anwendungsentwickler —
>
>   terrestris GmbH & Co. KG
>   Pützchens Chaussee 56
>   53227 Bonn
>
>   Tel:   +49 (0)228 / 96 28 99 -53
>   Fax:   +49 (0)228 / 96 28 99 -57
>
>   Email: jansen at terrestris.de
>   Web:   http://www.terrestris.de
>
>   Amtsgericht Bonn, HRA 6835, Komplementärin: terrestris Verwaltungs-
>   gesellschaft mbH, vertreten durch: Hinrich Paulsen, Till Adams
>
>
> _______________________________________________
> Dev mailing list
> Dev at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/openlayers-dev
>



--
Andreas Hocevar
OpenGeo - http://opengeo.org/
Expert service straight from the developers.