[ows.js] development update

[Marc Jansen]

Hi Juan Manuel,

great work indeed, this looks very promising.

I agree with Toms comments, especially the dist part. Most of your 
commits also include the changed dist-file which can be quite distracting.

Other comments (not a thorough review):

  * some typos in the README
  * some typos in the commit messages
  * IMO the README should use '#', '##' and friends for headings in a
    more structured way
  * I'd personally leave out the validator links in the example
  * the example itself isn't really self-explanatory

Nothing of the above is critical.

I'd love to get your work in, so others can built on top of this.

Thanks again & best regards,
Marc

On 14.03.2015 02:41, Tom Kralidis wrote:
> Hi Juan Manuel: great work! I'll dig deeper when the pr is submitted 
> but first comments for clarification:
>
> - should we abstract the js code setup for multiple versions? For 
> example I would like to start CSW 3 implementation
> - can we remove the dist/ directory from version control? The idea 
> being this should be a build / release step
>
> ..Tom
>
> Sent from my iPhone
>
> On Mar 13, 2015, at 17:21, Juan Manuel Vicente <juanma.v82 at gmail.com 
> <mailto:juanma.v82 at gmail.com>> wrote:
>
>> Hi guys,
>>
>> I done some updates, especially at the README. The library need some 
>> more work but I think it is a good start point to start using it.
>>
>> Can anyone do a peer-review before I make a pull request?[1]
>>
>> Thanks
>> Regards
>> Juan Manuel
>>
>> [1]https://github.com/juanmav/ows.js <https://github.com/juanmav/ows.js>
>>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/owsjs/attachments/20150315/8de84214/attachment.html>