[postgis-devel] The best way of adding the raster code

[Jorge Arévalo]

Hi Paul,

On Thu, Sep 23, 2010 at 7:51 PM, Paul Ramsey <pramsey at opengeo.org> wrote:
> I think rather than dropping a Makefile.in into the root, you should
> have a 'raster' target in GNUMakefile, a 'raster-clean' target, etc,
> etc.
>

Yes, I have that.


> The --with-raster flag in the configure.ac will set @values@ and also
> conditionally do the checks for the raster-only dependencies (GDAL).
>

I have that too.

> Inside the raster directory itself, you can have a Makefile.in, and in
> the case where the --with-raster flag was not set, it can just do
> nothing in its compile/clean/etc phases.
>

Ok, that's the part that differs.

In raster dir, I have a Makefile, that simply calls the Makefiles that
configure script creates in source directories (raster/rt_core,
raster/rt_pg). So, I could create a Makefile.in, instead having that
static Makefile, and only call the "make -c rt_core, make -c rt_pg"
instructions when "--with-raster" option is provided. It should work,
I guess...

> Then, when it's time to make raster a default/required part of the
> build (which will happen before 2.0), we just remove the --with-raster
> from config.ac and the checks in the Makefile.in in the raster
> directory.
>
> Sound OK?
>

Yes, I think sounds ok.

Many thanks!,

Jorge


> P
>
> 2010/9/23 Jorge Arévalo <jorge.arevalo at deimos-space.com>:
>> 2010/9/23 Jorge Arévalo <jorge.arevalo at deimos-space.com>:
>>> Hello,
>>>
>>> I'm adding the WKT Raster [1] (now PostGIS raster) code to the PostGIS
>>> trunk. I've created a separated folder, named "raster" in the PostGIS
>>> root. All the raster stuff is inside that folder. Then, I've added
>>> some macros on configure.ac, to configure the PostGIS Raster sources
>>> *only* if "--with-raster" option is provided at configure time.
>>>
>>> I've modified the GNUMakefile file to add the raster rules, but the
>>> point is I only want these rules added when I explicity say (with
>>> "--with-raster" option) I DO want to compile raster stuff at configure
>>> time.
>>>
>>> So, what's the best solution here? I want to cause the less impact to
>>> the current PostGIS source code, of course.
>>>
>>> Thanks in advance, and best regards,
>>>
>>
>> [1] http://trac.osgeo.org/postgis/wiki/WKTRaster
>>
>>
>> Sorry, I forgot to say my idea is I should create a Makefile.in file
>> at root level, and allow ./configure to generate raster stuff only in
>> case "--with-raster" option is provided. But I'm not sure.
>>
>> Thanks again,
>>
>>
>> --
>> Jorge Arévalo
>> Internet & Mobilty Division, DEIMOS
>> jorge.arevalo at deimos-space.com
>> http://mobility.grupodeimos.com/
>> http://gis4free.wordpress.com
>> _______________________________________________
>> postgis-devel mailing list
>> postgis-devel at postgis.refractions.net
>> http://postgis.refractions.net/mailman/listinfo/postgis-devel
>>
> _______________________________________________
> postgis-devel mailing list
> postgis-devel at postgis.refractions.net
> http://postgis.refractions.net/mailman/listinfo/postgis-devel
>