[postgis-devel] TPI with custom focal mean radius

[Luis Calisto]

Hey Regina,


Thanks for the interest. No problem with the current feature freeze, I think that's great if we have it for 3.0. Meanwhile I'll work on your proposed changes and if someone needs this functionality the new code/patch will be available.


For the code sprint I'd love to go and hack in PostGIS stuff but it will be difficult. I'm going to FOSS4G Tanzania and it will be difficult for me to justify this code sprint.

Thanks
Luis Calisto


________________________________
From: postgis-devel <postgis-devel-bounces at lists.osgeo.org> on behalf of Regina Obe <lr at pcorp.us>
Sent: Thursday, July 5, 2018 10:31 AM
To: 'PostGIS Development Discussion'
Subject: Re: [postgis-devel] TPI with custom focal mean radius


Luis,



Unfortunately we are at feature freeze for PostGIS 2.5.0, so this can't go into PostGIS 2.5.0 since it would change/add  signatures

We also wouldn't reopen the ticket, but would require a new ticket detailing the enhancement.



Could go in for next release which is tentatively planned to be 3.0 (at least a year's away).  We'll be focusing on this at  our upcoming code sprint in late September



https://trac.osgeo.org/postgis/wiki/PostGISCodeSprint2018



which you are welcome to join if you want to hack on PostGIS stuff.





That said, a couple of changes we'd need for this to accept.



Ideally, this would extend the existing ST_TPI with additional args, so the following changes would need to be made



1)      A new ticket detailing the enhancement

2)      Change name to ST_TPI

3)      Move the irad, and orad to the end – so that the signature is backward compatible with the existing ST_TPI signature.

4)      Add regression tests

5)      Amend  https://postgis.net/docs/RT_ST_TRI.html no include new signature

There's some other stuff about how you upgrade an existing function to accept new args, but I can take care of that and just explain for future contributions.



Thanks,

Regina



From: postgis-devel [mailto:postgis-devel-bounces at lists.osgeo.org] On Behalf Of Luis Calisto
Sent: Thursday, July 05, 2018 5:30 AM
To: postgis-devel at lists.osgeo.org
Subject: [postgis-devel] TPI with custom focal mean radius



Hi,





Current ST_TPI implementation only supports a focalmean radius of one. Out of need I had to implement a solution in PostGIS that implements TPI with a custom focal mean. This solution is now on my github: https://github.com/lcalisto/postgis_customTPI/ I believe it can be interesting to contribute this code to current ST_TPI implementation maybe someone else also needs it.



You think we should reopen this ticket? https://trac.osgeo.org/postgis/ticket/2163



If you think it's interesting I can also, and easily, do the same for TRI. https://postgis.net/docs/RT_ST_TRI.html





Regards



Luis Calisto


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/postgis-devel/attachments/20180705/3d343ca2/attachment-0001.html>