[postgis-devel] Function Removal

[Paul Ramsey]

> On Dec 16, 2020, at 12:12 PM, Regina Obe <lr at pcorp.us> wrote:
> 
> : RE: [postgis-devel] Function Removal
>> 
>>>  postgis=# select st_asewkt(ST_MakePoint(1.2, 2.33));
>>>  ERROR:  function st_makepoint(double precision, double precision) is
>>> not unique
>>>  HINT:  Could not choose a best candidate function. You might need to
>>> add explicit type casts.
>>> 
>>> Yeah, it could be either my new one or the two-parameter form of the
>>> old one.
>>> 
>>> The obvious fix would be to remove the old signatures at the same time
>>> as adding the new one, but as I recall this leads to upgrade issues?
>>> This is where my memory is failing. I know (a) a single signature with
>>> defaults and argument names is nicer and cleaner and also (b) every
>>> time I've done it there's been some kind of an outcry / mess.
>>> 
>>> Any help, thoughts?
>>> 
>>> P
>> 
>> This is for 3.2 (master) right, you aren't attempting this after we called
> RC1
>> right?
>> The solution (though it may have changed with strk's voodoo) is, you add
> the
>> drop statement in
>> 
>> postgis_before_upgrade.sql
>> 
>> 
>> 
> 
> One more note -- if you are replacing a C signature, you need to log the old
> one  in postgis_legacy.c  otherwise pg_upgrade will complain.

No,  hijacking the old signature.

> 
> _______________________________________________
> postgis-devel mailing list
> postgis-devel at lists.osgeo.org
> https://lists.osgeo.org/mailman/listinfo/postgis-devel