[postgis-devel] Pg13 upgrade issues?
Sandro Santilli
strk at kbt.io
Mon Sep 21 02:19:07 PDT 2020
On Thu, Sep 17, 2020 at 03:36:09PM -0700, Paul Ramsey wrote:
>
>
> > On Sep 15, 2020, at 10:05 AM, Sandro Santilli <strk at kbt.io> wrote:
> > packaged` suffix.
> >
> >> I tried your PR, and the core idea of a fake 'unpackaged' target seems miraculously to work, so there's just some polish to be added to the PR as far as I can tell. What do you feel are the drawbacks of it? The further we get away from 2.X, the less the "hackiness" of the solution matters in practical terms.
> >
> > I don't see drawbacks other than the "hackish" mode.
> > If you like that model, we can as well go for it.
> > If not else, it's ready...
>
> I'm fine w/ hackish, I think the PR needs some more work still, but I like that it mostly solves the problem.
>
> I have some additions to your branch here:
>
> https://git.osgeo.org/gitea/pramsey/postgis/src/branch/recover-unpackaged-tests
I've merged your changes into my branch and rebased them against master.
The result I force-pushed again to the branch associated to my PR.
> (I couldn't figure out how to submit a PR to your working branch. Maybe we can/should collab on a branch in the postgis repo?)
You couldn't because pull-requests were not enabled in my fork.
Now I enabled them and requesting a pull into my branch from yours
would be done with something like:
https://git.osgeo.org/gitea/strk/postgis/compare/recover-unpackaged-tests...pramsey:recover-unpackaged-tests
But really we don't need the web UI, this communication of yours is
just enough to merge manually as I did.
Next time feel free to push the branch to the official repo for
furhter collaboration
--strk;
More information about the postgis-devel
mailing list