[postgis-tickets] [PostGIS] #1984: geography_btree.c: array subscript is above array bounds [-Warray-bounds]

[PostGIS]

#1984: geography_btree.c: array subscript is above array bounds [-Warray-bounds]
---------------------+------------------------------------------------------
 Reporter:  strk     |       Owner:  pramsey      
     Type:  defect   |      Status:  new          
 Priority:  medium   |   Milestone:  PostGIS 2.1.0
Component:  postgis  |     Version:  trunk        
 Keywords:  history  |  
---------------------+------------------------------------------------------

Comment(by mcayland):

 I appreciate that we probably should have done this earlier during the
 cycle, but then again the excessive warnings have unmasked at least one
 potential crash bug that we should fix.

 In terms of risk, I'd say it's reasonably low: it's two self-contained
 macros that are used in several critical places during the index code (and
 it's really just changing the arithmetic to use direct pointer arithmetic
 with no logic change) and so if I made a mistake it would likely crash
 fairly quickly. I also introduced deliberate errors to both the pre- and
 post- patch version and confirmed that the regression tests failed in
 exactly the same way by diffing the files involved so it's already had a
 pretty good work out.

 Apologies if you feel slightly put out by this, but I genuinely feel that
 the benefits will far outweigh the drawbacks in this particular case.

-- 
Ticket URL: <http://trac.osgeo.org/postgis/ticket/1984#comment:10>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.