[postgis-tickets] [PostGIS] #3812: Changed 2" isn't numeric

[PostGIS]

#3812: Changed 2" isn't numeric
---------------------+---------------------------
 Reporter:  strk     |      Owner:  pramsey
     Type:  defect   |     Status:  new
 Priority:  medium   |  Milestone:  PostGIS 2.4.0
Component:  postgis  |    Version:  2.3.x
 Keywords:           |
---------------------+---------------------------
 I've noticed a couple of warnings upon generating postgis_upgrade.pl:
 {{{
 Argument "2\n-- Changed 2" isn't numeric in addition (+) at
 ../utils/postgis_proc_upgrade.pl line 105, <INPUT> line 3883.
 Argument "2\n-- Changed 2" isn't numeric in addition (+) at
 ../utils/postgis_proc_upgrade.pl line 105, <INPUT> line 3892.
 }}}

 These are due to a regexp assuming that above SQL objects you only find
 comments with a given version pattern:
 {{{
 .*(?:Availability|Changed|Updated):\s([^\.])\.([^.]*)
 }}}

 That is, Availability or Changed or Updated followed by a colon.

 Two comments broke the assumption:
 {{{
 -- Availability: 2.2
 -- Changed 2.4.0: marked parallel safe
 }}}

 And:
 {{{
 -- Availability: 2.2
 -- Changed 2.4.0: marked parallel safe
 }}}

 In other places the format was correct, like here:
 {{{
 -- Availability: 1.2.2
 -- Changed: 2.4.0 marked parallel safe
 CREATE AGGREGATE ST_Accum (geometry) (
 }}}

 The upgrade script will generate DROP and CREATE based on that
 information, so these errors should result in non-parallel safe aggregates
 on upgrade.
 It's a blocker.

--
Ticket URL: <https://trac.osgeo.org/postgis/ticket/3812>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.