[postgis-tickets] [PostGIS] #3101: Buffer overflow in pgsql2shp

[PostGIS]

#3101: Buffer overflow in pgsql2shp
-------------------------+---------------------------
  Reporter:  gabrimonfa  |      Owner:  pramsey
      Type:  defect      |     Status:  reopened
  Priority:  high        |  Milestone:  PostGIS 2.1.8
 Component:  postgis     |    Version:  2.2.x
Resolution:              |   Keywords:
-------------------------+---------------------------

Comment (by strk):

 {{{
 ==21601== Conditional jump or move depends on uninitialised value(s)
 ==21601==    at 0x4C30D29: strlen (in /usr/lib/valgrind
 /vgpreload_memcheck-amd64-linux.so)
 ==21601==    by 0x115C7B: ShpDumperOpenTable (pgsql2shp-core.c:1562)
 ==21601==    by 0x10AFDE: main (pgsql2shp-cli.c:191)
 ==21601==
 ==21601== Conditional jump or move depends on uninitialised value(s)
 ==21601==    at 0x51DA289: __strncat_chk (strncat_chk.c:36)
 ==21601==    by 0x115C93: strncat (string3.h:156)
 ==21601==    by 0x115C93: ShpDumperOpenTable (pgsql2shp-core.c:1562)
 ==21601==    by 0x10AFDE: main (pgsql2shp-cli.c:191)
 ==21601==
 ==21601==
 ==21601== Process terminating with default action of signal 6 (SIGABRT):
 dumping core
 ==21601==    at 0x50F777F: raise (raise.c:58)
 ==21601==    by 0x50F9379: abort (abort.c:89)
 ==21601==    by 0x513B08F: __libc_message (libc_fatal.c:175)
 ==21601==    by 0x51DCF83: __fortify_fail (fortify_fail.c:37)
 ==21601==    by 0x51DAEFF: __chk_fail (chk_fail.c:28)
 ==21601==    by 0x51DA2A2: __strncat_chk (strncat_chk.c:33)
 ==21601==    by 0x115C93: strncat (string3.h:156)
 ==21601==    by 0x115C93: ShpDumperOpenTable (pgsql2shp-core.c:1562)
 ==21601==    by 0x10AFDE: main (pgsql2shp-cli.c:191)
 }}}

 We don't have a good testsuite for pgsql2shp, would be useful to build
 one. Volunteers ?

--
Ticket URL: <https://trac.osgeo.org/postgis/ticket/3101#comment:9>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.