[postgis-tickets] [PostGIS] #3839: shp2pgsql cunit tests failing on Windows

[PostGIS]

#3839: shp2pgsql cunit tests failing on Windows
----------------------+---------------------------
  Reporter:  robe     |      Owner:  pramsey
      Type:  defect   |     Status:  new
  Priority:  medium   |  Milestone:  PostGIS 2.5.0
 Component:  postgis  |    Version:  2.3.x
Resolution:           |   Keywords:
----------------------+---------------------------

Comment (by robe):

 okay seemed to be crashing for me in the colmap_clean function.  Remarking
 that out made the error go away.  Though I can't figure out what I changed
 in my local to suddently start triggering the error.

 Anyway I'm seeing a bunch of questionable code in  shpcommon.c


 {{{
 colmap_dbf_by_pg(colmap *map, const char *pgname)
 {
   int i;
   for (i=0; i<map->size; ++i)
 }}}


 shouldn't the counter be incremented after be i++ and not before?

 anyway it disagrees with the colmap_clean code which has the counter
 incrementing after as I would expect it to.


 {{{
 colmap_clean(colmap *map)
 {
         int i;

         if (map->size)
         {
            for (i = 0; i < map->size; i++)
 }}}

--
Ticket URL: <https://trac.osgeo.org/postgis/ticket/3839#comment:2>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.