[postgis-tickets] [PostGIS] #3863: git builds always need upgrade

Sat Sep 23 11:35:35 PDT 2017

#3863: git builds always need upgrade
----------------------+---------------------------
  Reporter:  komzpa   |      Owner:  pramsey
      Type:  defect   |     Status:  new
  Priority:  medium   |  Milestone:  PostGIS 2.4.0
 Component:  postgis  |    Version:  trunk
Resolution:           |   Keywords:
----------------------+---------------------------

Comment (by robe):

 This might not be a global issue, might be something specific with how
 komzpa is setup.  Discussed on IRC with him.

 Travis who also builds from github does show revision numbers.  Though I
 forget what magic strk put in place to make that happen.

 {{{
 PostgreSQL 9.6.5 on x86_64-pc-linux-gnu, compiled by gcc (Ubuntu
 4.8.4-2ubuntu1~14.04.3) 4.8.4, 64-bit

   Postgis 2.4.0dev - r15801 - 2017-09-23 13:35:03

   scripts 2.4.0dev r15801

   raster scripts 2.4.0dev r15801

   GEOS: 3.5.0-CAPI-1.9.0 r4084

   PROJ: Rel. 4.8.0, 6 March 2012

   GDAL: GDAL 2.1.0, released 2016/04/25
 }}}

 winnie also build from git (git.osgeo.org) and she shows revision numbers
 as well.

 I'm going to install the extension files from winnie to make sure it's not
 happening during the generation of the extension files.

 Komzpaa, are you absolutely sure your make install is working and
 installing latest scripts.
 As I mentioned on IRC, even if revision number wasn't coming thru, I
 should still at least see a PGSQL=100 since
 PostGIS 2.4.0beta.  Yours is not showing that which makes me question if
 they are the latest.

 -- dialog from IRC below

 {{{
 07:38:23        Komzzpa:        POSTGIS="2.4.0dev" GEOS="3.7.0dev-
 CAPI-1.11.0 0" SFCGAL="1.3.1" PROJ="Rel. 4.9.3, 15 August 2016" GDAL="GDAL
 2.1.2, released 2016/10/24" LIBXML="2.9.4" LIBJSON="0.12.1" (core procs
 from "2.4.0dev" need upgrade) RASTER (raster procs from "2.4.0dev" need
 upgrade) (sfcgal procs from "2.4.0dev" need upgrade)
 07:38:54        Komzzpa:        alter extension postgis update to
 '2.4.0devnext'; alter extension postgis update to '2.4.0dev'; does not
 help to get rid of "need upgrade"
 07:39:06        Komzzpa:        what could we have broken?
 08:03:33        robe2:  Komzzpa hmm that is odd where were you upgrading
 from I thought it lists the r version though perhaps coming from git it
 doesn't
 08:04:35        robe2:  Komzzpa mine lists the svn version -
 POSTGIS="2.4.0dev r15800" PGSQL="100" GEOS="3.7.0dev-CAPI-1.11.0 316c4bc"
 SFCGAL="1.3.1" PROJ="Rel. 4.9.1, 04 March 2015" GDAL="GDAL 2.2.1, released
 2017/06/23" LIBXML="2.7.8" LIBJSON="0.12" LIBPROTOBUF="1.2.1" RASTER
 08:04:57        robe2:  it's very strange yours doesn't list PGSQL
 08:05:54        robe2:  you sure latest scripts got installed? perhaps the
 binaries got installed but the scripts didn't that would trigger that
 issue
 08:06:33        Komzzpa:        we've found that git builds make
 postgis_scripts_released='2.4.0dev r0' and
 postgis_scripts_installed='2.4.0'
 08:07:27        Komzzpa:        should I file a ticket?
 08:07:46        robe2:  Komzzpa hmm that's annoying. Yah that would be
 good
 08:08:06        robe2:  I think we might be looking at revision numbers
 though probably moving forward we'd have to stop that.
 08:08:54        robe2:  still even given that you should be seeing
 PGSQL=... in your output if you are installing latest scripts
 08:09:44        robe2:  A bug I found in earlier is the PGSQL compare was
 wrong so if you PGSQL you are using wasn't compiled with same gcc etc. as
 what you are runnig, it gave a bogus need upgrade message
 08:10:11        robe2:  at very least it should list PGSQL ... which means
 you don't have latest scripts installed.
 08:10:17        Komzzpa:        I think it's one of beta's
 08:10:43        Komzzpa:        I bumped into it exactly when tried to
 figure out which one :)
 08:11:11                * robe2 is going to miss revision numbers when we
 move to git
 08:11:17        robe2:  increasing that is
 08:11:39        Komzzpa:        you can implement commit counting :)
 08:11:56        robe2:  Komzzpa oh how do you do that
 08:12:42        Komzzpa:        kom at junocat postgis % git log | grep
 commit | wc -l
 08:12:43        Komzzpa:        11803
 08:12:49        Komzzpa:        in a brainless way
 08:13:11        Komzzpa:        probably some sophisticated exists
 08:14:12        Komzzpa:        it won't be precisely comparable in
 branches
 08:17:16        robe2:  Komzzpa though I have winnie building from
 git.osgeo.org and she has r versions -
 http://winnie.postgis.net:1500/job/PostGIS_EDB_Regress_winnie/5617/consoleFull
 08:17:17        sigq:   Title: PostGIS_EDB_Regress_winnie #5617 Console
 [Jenkins] (at winnie.postgis.net:1500)
 08:17:45        robe2:  not sure how that's happening unless building from
 github is different from git.osgeo.org (and strk has something cooked up
 there)
 08:18:47        Komzzpa:
 #POSTGIS_SVN_REVISION=passed_in_by_buildbot
 08:18:58        Komzzpa:        this may be a builder's trick
 08:21:32        robe2:  Komzzpa hmm I think I had put that in a while ago
 though I don't see it being used and where I'm passing it in anymore
 08:23:08        robe2:  Komzzpa travis has revision number too and he
 builds from git - https://travis-ci.org/postgis/postgis?branch=svn-trunk
 08:23:09        sigq:   Title: Travis CI - Test and Deploy Your Code with
 Confidence (at travis-ci.org)
 08:24:58        Komzzpa:        hmm
 08:25:19        Komzzpa:        may it be that it is chopped off somehow
 on deb build...
 }}}

--
Ticket URL: <https://trac.osgeo.org/postgis/ticket/3863#comment:1>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.