[postgis-tickets] [PostGIS] #4461: ST_AsTWKB doesn't always remove duplicate points

[PostGIS]

#4461: ST_AsTWKB doesn't always remove duplicate points
----------------------+---------------------------
  Reporter:  nicklas  |      Owner:  nicklas
      Type:  defect   |     Status:  new
  Priority:  medium   |  Milestone:  PostGIS 3.0.0
 Component:  postgis  |    Version:  trunk
Resolution:           |   Keywords:
----------------------+---------------------------

Comment (by Algunenano):

 > Any thoughts before I commit?

 {{{
  +      int max_points_left = pa->npoints;
 }}}

 This should use the same type as pa->npoints (uint32_t).


 {{{
 Index: liblwgeom/measures3d.c
 ===================================================================
 --- liblwgeom/measures3d.c      (revision 17618)
 +++ liblwgeom/measures3d.c      (working copy)
 @@ -1508,7 +1508,6 @@
                         pl->pv.z += vp.z / vl;
                 }
         }
 -
         return (!FP_IS_ZERO(pl->pv.x) || !FP_IS_ZERO(pl->pv.y) ||
 !FP_IS_ZERO(pl->pv.z));
  }

 }}}

 This part of the patch is unrelated.


 Can you also add tests around this, please?

-- 
Ticket URL: <https://trac.osgeo.org/postgis/ticket/4461#comment:2>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.