[postgis-tickets] r17634 - Fix undefined behaviour in _postgis_gserialized_stats

[Raul]

Author: algunenano
Date: 2019-07-29 08:33:47 -0700 (Mon, 29 Jul 2019)
New Revision: 17634

Modified:
   branches/2.5/NEWS
   branches/2.5/postgis/gserialized_estimate.c
Log:
Fix undefined behaviour in _postgis_gserialized_stats

References #4466



Modified: branches/2.5/NEWS
===================================================================
--- branches/2.5/NEWS	2019-07-29 15:33:04 UTC (rev 17633)
+++ branches/2.5/NEWS	2019-07-29 15:33:47 UTC (rev 17634)
@@ -12,6 +12,7 @@
   - #4406, Throw on invalid characters when decoding geohash (Raúl Marín)
   - #4440, Internal type lookups fail over FDW (Paul Ramsey)
   - #4445, Fix bug in lwgeom_le (Raúl Marín)
+  - #4466, Fix undefined behaviour in _postgis_gserialized_stats (Raúl Marín)
 
 
 PostGIS 2.5.2

Modified: branches/2.5/postgis/gserialized_estimate.c
===================================================================
--- branches/2.5/postgis/gserialized_estimate.c	2019-07-29 15:33:04 UTC (rev 17633)
+++ branches/2.5/postgis/gserialized_estimate.c	2019-07-29 15:33:47 UTC (rev 17634)
@@ -2072,10 +2072,6 @@
 	if ( ! PG_ARGISNULL(2) )
 		mode = text_p_get_mode(PG_GETARG_TEXT_P(2));
 
-	/* Check if we've been asked to only use stats from parent */
-	if ( ! PG_ARGISNULL(3) )
-		only_parent = PG_GETARG_BOOL(3);
-
 	/* Retrieve the stats object */
 	nd_stats = pg_get_nd_stats_by_name(table_oid, att_text, mode, only_parent);
 	if ( ! nd_stats )