[postgis-tickets] r17635 - Fix undefined behaviour in _postgis_gserialized_stats

[Raul]

Author: algunenano
Date: 2019-07-29 08:34:52 -0700 (Mon, 29 Jul 2019)
New Revision: 17635

Modified:
   trunk/NEWS
   trunk/postgis/gserialized_estimate.c
Log:
Fix undefined behaviour in _postgis_gserialized_stats

Closes #4466


Modified: trunk/NEWS
===================================================================
--- trunk/NEWS	2019-07-29 15:33:47 UTC (rev 17634)
+++ trunk/NEWS	2019-07-29 15:34:52 UTC (rev 17635)
@@ -17,6 +17,7 @@
   - #4453, Speed up ST_IsEmpty (Raúl Marín)
   - #4271, postgis_extensions_upgrade() also updates after pg_upgrade (Raúl Marín)
   - #4403, Support for shp2pgsql ability to reproject with copy mode (-D) (Regina Obe)
+  - #4466, Fix undefined behaviour in _postgis_gserialized_stats (Raúl Marín)
 
 PostGIS 3.0.0alpha3
 2019/07/01

Modified: trunk/postgis/gserialized_estimate.c
===================================================================
--- trunk/postgis/gserialized_estimate.c	2019-07-29 15:33:47 UTC (rev 17634)
+++ trunk/postgis/gserialized_estimate.c	2019-07-29 15:34:52 UTC (rev 17635)
@@ -2083,10 +2083,6 @@
 	if ( ! PG_ARGISNULL(2) )
 		mode = text_p_get_mode(PG_GETARG_TEXT_P(2));
 
-	/* Check if we've been asked to only use stats from parent */
-	if ( ! PG_ARGISNULL(3) )
-		only_parent = PG_GETARG_BOOL(3);
-
 	/* Retrieve the stats object */
 	nd_stats = pg_get_nd_stats_by_name(table_oid, att_text, mode, only_parent);
 	if ( ! nd_stats )