[postgis-tickets] [PostGIS] #4590: Upgrading PostGIS 3.0 PG 11 to PostGIS 3.0 PG 12 errors after pg_upgrade - st_linecrossingdirection

[PostGIS]

#4590: Upgrading PostGIS 3.0 PG 11 to PostGIS 3.0 PG 12 errors after pg_upgrade -
st_linecrossingdirection
------------------------------------+---------------------------
  Reporter:  robe                   |      Owner:  strk
      Type:  defect                 |     Status:  reopened
  Priority:  medium                 |  Milestone:  PostGIS 3.0.1
 Component:  build/upgrade/install  |    Version:  3.0.x
Resolution:                         |   Keywords:
------------------------------------+---------------------------
Changes (by strk):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 I'm confused by the changeset, I see:

 >  -- Availability: 1.4.0
 > -CREATE OR REPLACE FUNCTION ST_LineCrossingDirection(geom1 geometry,
 geom2 geometry)
 > +CREATE OR REPLACE FUNCTION ST_LineCrossingDirection(line1 geometry,
 line2 geometry)
 >   RETURNS integer

 Which means a function signature is changed. For a function which is
 advertised as being available since PostGIS 1.4.0. What's the deal, could
 you summarize what happened ? Did we ship a broken version of PostGIS
 which changed signature without adding a {{{-- Changed}}} comment ?

 Changing the signature back means whoever installed the broken PostGIS
 would fail upgrading again.

-- 
Ticket URL: <https://trac.osgeo.org/postgis/ticket/4590#comment:6>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.