[postgis-tickets] [PostGIS] #4603: Windows build failing in shp2pgsql: XError in psSHP->sHooks.FWrite()

[PostGIS]

#4603: Windows build failing in shp2pgsql: XError in psSHP->sHooks.FWrite()
----------------------------+---------------------------
  Reporter:  Algunenano     |      Owner:  pramsey
      Type:  defect         |     Status:  new
  Priority:  high           |  Milestone:  PostGIS 3.1.0
 Component:  loader/dumper  |    Version:  master
Resolution:                 |   Keywords:
----------------------------+---------------------------

Comment (by robe):

 Okay as the error says "No Error".  It is failing

 {{{

 Dumping: XError in psSHP->sHooks.FWrite() while writing object of 28 bytes
 to .shp file: No error
 Error writing shape 0
 }}}

 The issue is in the shpopen.c file.  If I swap with the older it works
 fine.

 Also seems to work fine if I change this line


 {{{
 if ( psSHP->sHooks.FWrite( pabyRec, nRecordSize, 1, psSHP->fpSHP ) ) < 1
 }}}

 to

 if ( psSHP->sHooks.FWrite( pabyRec, nRecordSize, 1, psSHP->fpSHP ) ) < 0

 it's returning 0 so is being sent into that error loop

-- 
Ticket URL: <https://trac.osgeo.org/postgis/ticket/4603#comment:4>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.