[postgis-tickets] [PostGIS] #4963: PostGIS 2.5 compile fails DIST2DTEST - GEOS < 3.9? (was: PostGIS 2.5 compile fail on windows (mingw64) and dronie)

[PostGIS]

#4963: PostGIS 2.5 compile fails DIST2DTEST  - GEOS < 3.9?
----------------------+---------------------------
  Reporter:  robe     |      Owner:  pramsey
      Type:  defect   |     Status:  new
  Priority:  blocker  |  Milestone:  PostGIS 2.5.6
 Component:  postgis  |    Version:  2.5.x
Resolution:           |   Keywords:
----------------------+---------------------------

Comment (by robe):

 Okay I have a suspicion this fails on all bots running geos < 3.9

 Debbie is having the same issue too:

 https://debbie.postgis.net/job/PostGIS_Regress/17356/consoleFull


 {{{
 00:57:23  -------------- Dependencies --------------
 00:57:23   GEOS config:
 /var/lib/jenkins/workspace/geos/rel-3.7w64/bin/geos-config
 00:57:23   GEOS version:         3.7.4dev
 00:57:23   GDAL config:
 /var/lib/jenkins/workspace/gdal/rel-2.4w64/bin/gdal-config
 00:57:23   GDAL version:         2.4.4
 00:57:23   SFCGAL config:        /usr/bin/sfcgal-config
 00:57:23   SFCGAL version:       1.3.8
 00:57:23   PostgreSQL config:
 /var/lib/jenkins/workspace/pg/rel/pg9.5w64/bin/pg_config
 00:57:23   PostgreSQL version:   PostgreSQL 9.5.25
 00:57:23   PROJ4 version:        72
 00:57:23   Libxml2 config:       /usr/bin/xml2-config
 00:57:23   Libxml2 version:      2.9.12
 00:57:23   JSON-C support:       yes
 00:57:23   protobuf-c support:   yes
 00:57:23   protobuf-c version:   1003003
 00:57:23   PCRE support:         no
 00:57:23   Perl:                 /usr/bin/perl
 00:57:23
 00:57:23  --------------- Extensions ---------------

 01:00:07 cu_measures.c: In function ‘test_mindistance2d_tolerance’:
 01:00:07 cu_measures.c:209:71: error: macro "DIST2DTEST" passed 4
 arguments, but takes just 3
 01:00:07   209 |   "POINT(5433865 8243495)", 2271704.2698450615,
 default_accepted_error);
 01:00:07       |
 ^
 01:00:07 cu_measures.c:33: note: macro "DIST2DTEST" defined here
 01:00:07    33 | #define DIST2DTEST(str1, str2, res) \
 01:00:07       |
 01:00:07 cu_measures.c:207:2: error: ‘DIST2DTEST’ undeclared (first use in
 this function); did you mean ‘DISTPTS’?
 01:00:07   207 |  DIST2DTEST(
 01:00:07       |  ^~~~~~~~~~
 01:00:07       |  DISTPTS
 01:00:07 cu_measures.c:207:2: note: each undeclared identifier is reported
 only once for each function it appears in
 01:00:07 make[2]: *** [Makefile:98: cu_measures.o] Error 1
 01:00:07 make[2]: Leaving directory
 '/var/lib/jenkins/workspace/postgis/branches/2.5/liblwgeom/cunit'
 01:00:07 make[1]: *** [Makefile:204: check] Error 2
 01:00:07 make[1]: Leaving directory
 '/var/lib/jenkins/workspace/postgis/branches/2.5/liblwgeom'
 01:00:07 make: *** [GNUmakefile:16: check] Error 1
 01:00:07 Build step 'Execute shell' marked build as failure
 01:00:07 Triggering a new build of PostgreSQL stop
 01:00:07 Finished: FAILURE
 }}}

-- 
Ticket URL: <https://trac.osgeo.org/postgis/ticket/4963#comment:3>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.