[postgis-tickets] [PostGIS] #5002: liblwgeom builds with no warning flags by default

[PostGIS]

#5002: liblwgeom builds with no warning flags by default
------------------------------------+---------------------------
  Reporter:  strk                   |      Owner:  strk
      Type:  defect                 |     Status:  new
  Priority:  medium                 |  Milestone:  PostGIS 3.2.0
 Component:  build/upgrade/install  |    Version:  master
Resolution:                         |   Keywords:
------------------------------------+---------------------------

Comment (by Algunenano):

 > I think we want all warnings enabled by default, as it happens under
 postgis/

 That's not correct. As you mentioned later, postgis/ gets any extra flags
 declared by postgresql, so your '-Wall' likely comes from Postgresql
 compilation.



 > Algunenano do you agree to re-add -Wall to CFLAGS ?

 I'm not against it as long as it's added everywhere, that is, to all build
 files and not only to certain folders.


 Have you considered setting up your environment variables to match your
 development requirements? For example, my CFLAGS look something like this:
 {{{
 -march=native -mtune=native -O3 -pipe -fno-plt -fexceptions
 -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -fstack-clash-
 protection -fcf-protection -Wall -Wextra -Wno-unused-parameter -g3 -gdwarf
 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer
 }}}

 And whenever I build a project (Postgis or any other) I use those flags. I
 don't have to depend on whether autotools, cmake or whatever is used by
 the project, sets warnings or not, only how to pass my flags.

-- 
Ticket URL: <https://trac.osgeo.org/postgis/ticket/5002#comment:4>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.