[postgis-tickets] [PostGIS] #5494: st_dwithin(text, text, float8) is marked as deprecated and installed by the same postgis version

[PostGIS]

#5494: st_dwithin(text,text,float8) is marked as deprecated and installed by the
same postgis version
----------------------------------------------+---------------------------
 Reporter:  strk                              |      Owner:  pramsey
     Type:  defect                            |     Status:  new
 Priority:  critical                          |  Milestone:  PostGIS 3.4.1
Component:  postgis                           |    Version:  3.4.x
 Keywords:  upgrade, deprecation, st_dwithin  |
----------------------------------------------+---------------------------
 See this:
 {{{
 postgis_reg=# create extension postgis version '3.4.0';
 CREATE EXTENSION
 postgis_reg=# select oid::regprocedure, proargnames from pg_proc where
 proname = 'st_dwithin';
                            oid                            |
 proargnames
 ----------------------------------------------------------+--------------------------------------
  st_dwithin(text,text,double precision)                   |
  st_dwithin(geometry,geometry,double precision)           |
 {geom1,geom2,""}
  st_dwithin(geography,geography,double precision,boolean) |
 {geog1,geog2,tolerance,use_spheroid}
 (3 rows)
 postgis_reg=# create view lockit as select st_dwithin(null::text,
 null::text, null::float8);
 CREATE VIEW
 postgis_reg=# alter extension postgis update to 'ANY';
 ALTER EXTENSION
 postgis_reg=# alter extension postgis update to '3.4.0';
 WARNING:  Deprecated function
 st_dwithin_deprecated_by_postgis_300(text,text,double precision) left
 behind: cannot drop function
 st_dwithin_deprecated_by_postgis_300(text,text,double precision) because
 other objects depend on it
 DETAIL:  view lockit depends on function
 st_dwithin_deprecated_by_postgis_300(text,text,double precision)
 HINT:  Replace the view changing all occurrences of
 st_dwithin_deprecated_by_postgis_300(text,text,double precision) in its
 definition with st_dwithin and upgrade again
 ALTER EXTENSION
 }}}

 What's happening is that the script to upgrade to 3.4.0 is saying that
 PostGIS-3.0.0 deprecated the `ST_DWithin(text,text,float8)` function, but
 this is clearly not the case, as PostGIS-3.4.0 is providing it !

 This was initially reported as #5486 bot it's now more clear
-- 
Ticket URL: <https://trac.osgeo.org/postgis/ticket/5494>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.