[PostGIS] #5935: GHA latest failing on GDAL 3.12dev with deprecated notice

[PostGIS]

#5935: GHA latest failing on GDAL 3.12dev with deprecated notice
----------------------+---------------------------
  Reporter:  robe     |      Owner:  pramsey
      Type:  defect   |     Status:  new
  Priority:  blocker  |  Milestone:  PostGIS 3.6.0
 Component:  raster   |    Version:  3.5.x
Resolution:           |   Keywords:
----------------------+---------------------------
Changes (by robe):

 * owner:  robe => pramsey


Old description:

> {{{
>
> -------------- Dependencies --------------
>   GEOS config:          /usr/bin/pkg-config geos
>   GEOS version:         3.14.0dev (31400)
>   GDAL config:          /usr/local/bin/gdal-config
>   GDAL version:         3.12.0dev (31200)
>   SFCGAL config:        /usr/local/bin/sfcgal-config
>   SFCGAL version:       2.2.0
>   PostgreSQL config:    /usr/local/pgsql/bin/pg_config
>   PostgreSQL version:   PostgreSQL 18beta1
>   PROJ version:         9.7.0 (90700)
>   Libxml2 config:       /usr/bin/xml2-config
>   Libxml2 version:      2.9.14
>   JSON-C support:       yes
>   protobuf support:     yes
>   protobuf-c version:   1004001
>   PCRE support:         Version 1
>   Perl:                 /usr/bin/perl
> rm -f rtpostgis_upgrade_cleanup.sql.tmp
> echo 'BEGIN;' > rtpostgis_upgrade.sql
> cat ../../postgis/common_before_upgrade.sql rtpostgis_upgrade_cleanup.sql
> rtpostgis_upgrade.sql.in rtpostgis_drop.sql
> ../../postgis/common_after_upgrade.sql | sed -e 's/^BEGIN;$//' -e
> 's/^COMMIT;$//' >> rtpostgis_upgrade.sql
> echo 'COMMIT;' >> rtpostgis_upgrade.sql
> rtpg_gdal.c: In function 'RASTER_InterpolateRaster':
> rtpg_gdal.c:736:9: error: 'GDALGetDataTypeSize' is deprecated [-Werror
> =deprecated-declarations]
>   736 |         in_band_gdaltype_size =
> GDALGetDataTypeSize(in_band_gdaltype) / 8;
>       |         ^~~~~~~~~~~~~~~~~~~~~
> In file included from ./../rt_core/librtcore.h:125,
>                  from rtpostgis.h:39,
>                  from rtpg_gdal.c:44:
> /usr/local/include/gdal.h:70:25: note: declared here
>    70 | int CPL_DLL CPL_STDCALL GDALGetDataTypeSize(GDALDataType)
>       |                         ^~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> make[3]: *** [<builtin>: rtpg_gdal.o] Error 1
> make[3]: *** Waiting for unfinished jobs....
> make[3]: Leaving directory '/src/postgis/raster/rt_pg'
> make[2]: Leaving directory '/src/postgis/raster'
> make[2]: *** [Makefile:41: pglib] Error 2
> make[1]: *** [Makefile:29: all] Error 2
> make[1]: Leaving directory '/src/postgis/raster'
> make: *** [GNUmakefile:36: all] Error 1
> }}}

New description:

 {{{

 -------------- Dependencies --------------
   GEOS config:          /usr/bin/pkg-config geos
   GEOS version:         3.14.0dev (31400)
   GDAL config:          /usr/local/bin/gdal-config
   GDAL version:         3.12.0dev (31200)
   SFCGAL config:        /usr/local/bin/sfcgal-config
   SFCGAL version:       2.2.0
   PostgreSQL config:    /usr/local/pgsql/bin/pg_config
   PostgreSQL version:   PostgreSQL 18beta1
   PROJ version:         9.7.0 (90700)
   Libxml2 config:       /usr/bin/xml2-config
   Libxml2 version:      2.9.14
   JSON-C support:       yes
   protobuf support:     yes
   protobuf-c version:   1004001
   PCRE support:         Version 1
   Perl:                 /usr/bin/perl
 rm -f rtpostgis_upgrade_cleanup.sql.tmp
 echo 'BEGIN;' > rtpostgis_upgrade.sql
 cat ../../postgis/common_before_upgrade.sql rtpostgis_upgrade_cleanup.sql
 rtpostgis_upgrade.sql.in rtpostgis_drop.sql
 ../../postgis/common_after_upgrade.sql | sed -e 's/^BEGIN;$//' -e
 's/^COMMIT;$//' >> rtpostgis_upgrade.sql
 echo 'COMMIT;' >> rtpostgis_upgrade.sql
 rtpg_gdal.c: In function 'RASTER_InterpolateRaster':
 rtpg_gdal.c:736:9: error: 'GDALGetDataTypeSize' is deprecated [-Werror
 =deprecated-declarations]
   736 |         in_band_gdaltype_size =
 GDALGetDataTypeSize(in_band_gdaltype) / 8;
       |         ^~~~~~~~~~~~~~~~~~~~~
 In file included from ./../rt_core/librtcore.h:125,
                  from rtpostgis.h:39,
                  from rtpg_gdal.c:44:
 /usr/local/include/gdal.h:70:25: note: declared here
    70 | int CPL_DLL CPL_STDCALL GDALGetDataTypeSize(GDALDataType)
       |                         ^~~~~~~~~~~~~~~~~~~
 cc1: all warnings being treated as errors
 make[3]: *** [<builtin>: rtpg_gdal.o] Error 1
 make[3]: *** Waiting for unfinished jobs....
 make[3]: Leaving directory '/src/postgis/raster/rt_pg'
 make[2]: Leaving directory '/src/postgis/raster'
 make[2]: *** [Makefile:41: pglib] Error 2
 make[1]: *** [Makefile:29: all] Error 2
 make[1]: Leaving directory '/src/postgis/raster'
 make: *** [GNUmakefile:36: all] Error 1
 }}}

--
Comment:

 @pramsey,

 I figure since you are going to be making changes to raster, might as well
 fix this too :)
-- 
Ticket URL: <https://trac.osgeo.org/postgis/ticket/5935#comment:1>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.