[PostGIS] #6041: PostGIS 3.0 no longer compiles against PG 9.6

[PostGIS]

#6041: PostGIS 3.0 no longer compiles against PG 9.6
---------------------+----------------------------
 Reporter:  robe     |      Owner:  pramsey
     Type:  defect   |     Status:  new
 Priority:  blocker  |  Milestone:  PostGIS 3.0.12
Component:  postgis  |    Version:  3.5.x
 Keywords:           |
---------------------+----------------------------
 I think something got added to PostGIS 3.0 that is incompatible with 9.6.
 Debbie can no longer compile it.

 https://debbie.postgis.net/job/PostGIS_Regress/36700
 {{{
 02:58:06 make[2]: Entering directory
 '/var/lib/jenkins/workspace/postgis/branches/3.0/raster/rt_pg'
 02:58:06 gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-
 after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-
 security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-
 format-truncation -Wno-stringop-truncation -g -O2 -fPIC
 "-I../../liblwgeom"  -I/var/lib/jenkins/workspace/geos/rel-3.10w64/include
 -I/usr/include/x86_64-linux-gnu -I/usr/include/webp -isystem /usr/include
 /mit-krb5 -I/usr/include/p11-kit-1   -I/usr/include/libxml2 -I/usr/include
 -I/usr/include/json-c    -std=gnu99 -g -O2 -fno-math-errno -fno-signed-
 zeros -I/var/lib/jenkins/workspace/gdal/rel-3.10w64/include
 "-I../../libpgcommon" -I/usr/include/x86_64-linux-gnu -I/usr/include/webp
 -isystem /usr/include/mit-krb5 -I/usr/include/p11-kit-1  -I../rt_core -I.
 -I./
 -I/var/lib/jenkins/workspace/pg/rel/pg9.6w64/include/postgresql/server
 -I/var/lib/jenkins/workspace/pg/rel/pg9.6w64/include/postgresql/internal
 -D_GNU_SOURCE   -c -o rtpostgis.o rtpostgis.c
 02:58:06 rtpostgis.c: In function ‘_PG_init’:
 02:58:06 rtpostgis.c:545:25: error: passing argument 4 of
 ‘DefineCustomBoolVariable’ from incompatible pointer type [-Wincompatible-
 pointer-types]
 02:58:06   545 |                         &enable_outdb_rasters, /*
 valueAddr */
 02:58:06       |                         ^~~~~~~~~~~~~~~~~~~~~
 02:58:06       |                         |
 02:58:06       |                         _Bool *
 02:58:06 In file included from rtpostgis.c:134:
 02:58:06
 /var/lib/jenkins/workspace/pg/rel/pg9.6w64/include/postgresql/server/utils/guc.h:286:56:
 note: expected ‘bool *’ {aka ‘char *’} but argument is of type ‘_Bool *’
 02:58:06   286 |                                                  bool
 *valueAddr,
 02:58:06       |
 ~~~~~~^~~~~~~~~
 02:58:06 rtpostgis.c:550:25: error: passing argument 9 of
 ‘DefineCustomBoolVariable’ from incompatible pointer type [-Wincompatible-
 pointer-types]
 02:58:06   550 |
 rtpg_assignHookEnableOutDBRasters, /* GucBoolAssignHook assign_hook */
 02:58:06       |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 02:58:06       |                         |
 02:58:06       |                         void (*)(_Bool,  void *)
 02:58:06
 /var/lib/jenkins/workspace/pg/rel/pg9.6w64/include/postgresql/server/utils/guc.h:291:68:
 note: expected ‘GucBoolAssignHook’ {aka ‘void (*)(char,  void *)’} but
 argument is of type ‘void (*)(_Bool,  void *)’
 02:58:06   291 |
 GucBoolAssignHook assign_hook,
 02:58:06       |
 ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
 02:58:06 make[2]: *** [<builtin>: rtpostgis.o] Error 1
 02:58:06 make[2]: Leaving directory
 '/var/lib/jenkins/workspace/postgis/branches/3.0/raster/rt_pg'
 02:58:06 make[1]: *** [Makefile:32: pglib] Error 2
 02:58:06 make[1]: Leaving directory
 '/var/lib/jenkins/workspace/postgis/branches/3.0/raster'
 02:58:06 make: *** [GNUmakefile:20: all] Error 1
 02:58:06 Build step 'Execute shell' marked build as failure
 02:58:06 [Gitea] do not publish assets due to build being non-Successfully
 02:58:06 Triggering a new build of PostgreSQL stop
 02:58:06 Finished: FAILURE
 }}}
-- 
Ticket URL: <https://trac.osgeo.org/postgis/ticket/6041>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.