[PROJ] PROJ 6.0.0RC3

[Greg Troxel]

Even Rouault <even.rouault at spatialys.com> writes:

>> The C++ unit tests also fail on io.wkt_parsing_with_parenthesis. I've been
>> unable to determine the cause. Presumably the use of non-ASCII characters in
>> hexadecimal form. Not sure why this would be netBSD specific... But this is
>> is really a non-critical test.
>
> Actually was a misuse of isspace() on non-ASCII characters. Could have shown 
> up on other platforms as well. Just fixed in the
> https://github.com/OSGeo/proj.4/pull/1293 as well

NetBSD's toupper/isspace/etc. functions are believed to be standards
compliant but are somewhat unforgiving when called out of bounds.  So it
makes sense that such a problem showed up there first.

> Now 'gmake check' passes on netBSD 8

I just updated to RC4 and rebuilt.  "make test" in pkgsrc, which runs
"gmake check" in proj, passed.

There are new files and missing files relative to 5.2.0, but that's
expected and I'll be going through that.  I'll also test the pkgsrc
build on mac and on older NetBSD and i386 and earmv7.

Thanks for doing the install and debugging this before I got to it!





The "test ==" problem in configure is still present.  I actually patched
configure instead, so as not to regenerate it, but this is the change
backported to configure.ac

--- configure.ac.~1~	2019-02-12 14:45:37.000000000 -0500
+++ configure.ac	2019-02-26 18:35:01.003470043 -0500
@@ -326,7 +326,7 @@
             AS_HELP_STRING([--with-external-gtest],
                [Whether to use external Google Test]),,)
 
-if test "x$with_external_gtest" == "xyes" ; then
+if test "x$with_external_gtest" = "xyes" ; then
     AC_MSG_RESULT([using external GTest.])
     PKG_CHECK_MODULES([GTEST], [gtest >= 1.8.0])
 else
@@ -334,7 +334,7 @@
     GTEST_CFLAGS="-I\$(top_srcdir)/test/googletest/include"
     GTEST_LIBS="\$(top_builddir)/test/googletest/libgtest.la"
 fi
-AM_CONDITIONAL(USE_EXTERNAL_GTEST, [test "x$with_external_gtest" == "xyes"])
+AM_CONDITIONAL(USE_EXTERNAL_GTEST, [test "x$with_external_gtest" = "xyes"])
 AC_SUBST(GTEST_CFLAGS,$GTEST_CFLAGS)
 AC_SUBST(GTEST_LIBS,$GTEST_LIBS)