[PyWPS-dev] master or develop

[Adam Laža]

Hi David,

check my bug fix [1]. It works for me but I would like to know if it is
right approach.

Cheers,
Adam

[1]:
https://github.com/lazaa32/pywps/commit/5cccc38c997965d4566b21df0badf3244021bdeb

st 12. 12. 2018 v 2:32 odesílatel David Huard <huard.david at ouranos.ca>
napsal:

> Hi Adam,
>
> I think we have the same issue :
> https://github.com/geopython/pywps/issues/412
>
> My guess is that it's either due to my refactoring or to the new templates
> or a combination of both.
>
> I noticed that if you do
> ComplexOutput.data = <file content>
> ... then it works
> but if you do
> ComplexOutput.file =  <file path>
> it doesn't. Hopefully this is a hint as to what is going wrong.
>
> I think the offending bit is is inout.outputs.ComplexOutput. If the
> ComplexOutput is a file and as_reference is False, _json_data is called
> which I think might fail to fill the json data field. It's not obvious why
> though. Do you have a test case you could add to the test suite ?
>
> HTH,
>
> David
>
>
>
>
> On Tue, Dec 11, 2018 at 4:06 AM Adam Laža <ad.laza32 at gmail.com> wrote:
>
>> Hi Carsten,
>>
>> thanks for reply. Good to know. However since I switched for master
>> branch I can get output in ExecuteResponse only as reference. Even if I
>> force attribute asReference=false I still get only reference to output, not
>> the output directly.
>> I use pywps-flask demo server and Buffer process for testing. Any idea
>> what could be wrong?
>>
>> Cheers,
>> Adam
>>
>> út 11. 12. 2018 v 0:16 odesílatel Carsten Ehbrecht <ehbrecht at dkrz.de>
>> napsal:
>>
>>> Hi Adam,
>>>
>>> yes, please use master branch to rebase. We switched awhile ago (Code
>>> sprint Bonn in March?).
>>>
>>> Cheers,
>>> Carsten
>>>
>>> > On 8 Dec 2018, at 04:16, Adam Laža <ad.laza32 at gmail.com> wrote:
>>> >
>>> > Hi devs,
>>> >
>>> > I'd like to make a new PR for my Docker extension in few days. Now I'm
>>> just bit confused because I wanted to rebase my branch onto develop branch
>>> to avoid conflicts but it seems to me that develop branch is no more used
>>> and that you use master instead (develop has last commit July 16, master 26
>>> days ago).
>>> >
>>> > Could anyone confirm that right approach is to rebase onto master and
>>> make a PR against master?
>>> >
>>> > Thanks,
>>> > Adam
>>> > _______________________________________________
>>> > pywps-dev mailing list
>>> > pywps-dev at lists.osgeo.org
>>> > https://lists.osgeo.org/mailman/listinfo/pywps-dev
>>>
>>> _______________________________________________
>> pywps-dev mailing list
>> pywps-dev at lists.osgeo.org
>> https://lists.osgeo.org/mailman/listinfo/pywps-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/pywps-dev/attachments/20181212/3d2d95fe/attachment.html>