[QGIS Commit] r14414 - trunk/qgis/src/app

[svn_qgis at osgeo.org]

Author: jef
Date: 2010-10-19 06:51:43 -0700 (Tue, 19 Oct 2010)
New Revision: 14414

Modified:
   trunk/qgis/src/app/qgsattributedialog.cpp
   trunk/qgis/src/app/qgsidentifyresults.cpp
Log:
fix #2950

Modified: trunk/qgis/src/app/qgsattributedialog.cpp
===================================================================
--- trunk/qgis/src/app/qgsattributedialog.cpp	2010-10-19 10:25:28 UTC (rev 14413)
+++ trunk/qgis/src/app/qgsattributedialog.cpp	2010-10-19 13:51:43 UTC (rev 14414)
@@ -303,11 +303,14 @@
 
 void QgsAttributeDialog::show()
 {
-  mDialog->setAttribute( Qt::WA_DeleteOnClose );
-  mDialog->show();
-  mDialog->raise();
-  mDialog->activateWindow();
-  mDialog->installEventFilter( this );
+  if ( mDialog )
+  {
+    mDialog->setAttribute( Qt::WA_DeleteOnClose );
+    mDialog->show();
+    mDialog->raise();
+    mDialog->activateWindow();
+    mDialog->installEventFilter( this );
+  }
 }
 
 void QgsAttributeDialog::saveGeometry()

Modified: trunk/qgis/src/app/qgsidentifyresults.cpp
===================================================================
--- trunk/qgis/src/app/qgsidentifyresults.cpp	2010-10-19 10:25:28 UTC (rev 14413)
+++ trunk/qgis/src/app/qgsidentifyresults.cpp	2010-10-19 13:51:43 UTC (rev 14414)
@@ -214,27 +214,33 @@
     }
   }
 
-  QTreeWidgetItem *actionItem = new QTreeWidgetItem( QStringList() << tr( "(Actions)" ) );
-  actionItem->setData( 0, Qt::UserRole, "actions" );
-  featItem->addChild( actionItem );
+  if ( vlayer->pendingFields().size() > 0 || vlayer->actions()->size() )
+  {
+    QTreeWidgetItem *actionItem = new QTreeWidgetItem( QStringList() << tr( "(Actions)" ) );
+    actionItem->setData( 0, Qt::UserRole, "actions" );
+    featItem->addChild( actionItem );
 
-  QTreeWidgetItem *editItem = new QTreeWidgetItem( QStringList() << "" << ( vlayer->isEditable() ? tr( "Edit feature form" ) : tr( "View feature form" ) ) );
-  editItem->setIcon( 0, QgisApp::getThemeIcon( vlayer->isEditable() ? "/mIconEditable.png" : "/mIconEditable.png" ) );
-  editItem->setData( 0, Qt::UserRole, "edit" );
-  actionItem->addChild( editItem );
+    if ( vlayer->pendingFields().size() > 0 )
+    {
+      QTreeWidgetItem *editItem = new QTreeWidgetItem( QStringList() << "" << ( vlayer->isEditable() ? tr( "Edit feature form" ) : tr( "View feature form" ) ) );
+      editItem->setIcon( 0, QgisApp::getThemeIcon( vlayer->isEditable() ? "/mIconEditable.png" : "/mIconEditable.png" ) );
+      editItem->setData( 0, Qt::UserRole, "edit" );
+      actionItem->addChild( editItem );
+    }
 
-  for ( int i = 0; i < vlayer->actions()->size(); i++ )
-  {
-    const QgsAction &action = vlayer->actions()->at( i );
+    for ( int i = 0; i < vlayer->actions()->size(); i++ )
+    {
+      const QgsAction &action = vlayer->actions()->at( i );
 
-    if ( !action.runable() )
-      continue;
+      if ( !action.runable() )
+        continue;
 
-    QTreeWidgetItem *twi = new QTreeWidgetItem( QStringList() << "" << action.name() );
-    twi->setIcon( 0, QgisApp::getThemeIcon( "/mAction.png" ) );
-    twi->setData( 0, Qt::UserRole, "action" );
-    twi->setData( 0, Qt::UserRole + 1, QVariant::fromValue( i ) );
-    actionItem->addChild( twi );
+      QTreeWidgetItem *twi = new QTreeWidgetItem( QStringList() << "" << action.name() );
+      twi->setIcon( 0, QgisApp::getThemeIcon( "/mAction.png" ) );
+      twi->setData( 0, Qt::UserRole, "action" );
+      twi->setData( 0, Qt::UserRole + 1, QVariant::fromValue( i ) );
+      actionItem->addChild( twi );
+    }
   }
 
   highlightFeature( featItem );