[Qgis-developer] [QGIS Commit] SVN [godofredo] r7284 - branches/ogr-plugin-branch/src/app

[godofredo contreras]

Hi Martin:

I´m working in fixing the dependency introduced by the files in dbutilities of core
what do you think about this organization of files in dbutilities:

qgsurimanager  will be deprecated and qgsdatasourceuri will be used
qgsconnectionmanager has no extra dependencies and could be kept in core/dbutilities
qgsconnection has no extra dependencies and could be kept in core/dbutilities
qgsdatabaseconnectionbase is used as an interface for (qgspostgresdatabaseconnection and qgsogrdatabaseconnection) has no extra
                       dependencies and could be kept in core/dbutilities
qgsgeomcolumntypethread and qgspostgresdatabaseconnection are postgres specific (not really sure) if they are moved to providers
                       then I need to add a dependency in app to postgres provider
qgsogrdatabaseconnection is ogr specific, same case that the above one

Regards 

Godofredo Contreras





> Date: Wed, 24 Oct 2007 14:03:05 +0200
> From: wonder.sk at gmail.com
> To: frdcn at hotmail.com
> Subject: Re: [Qgis-developer] [QGIS Commit] SVN [godofredo] r7284 - branches/ogr-plugin-branch/src/app
> CC: tutey at o2.pl; qgis-developer at lists.qgis.org
> 
> Hi Godofredo,
> 
> when briefly looking at your changes I have some notes:
> - it seems that QgsURIManager class does pretty much the same as
> QgsDataSourceURI class which is already a part of core library
> - you've introduced postresql dependency to core library - this is not
> a good thing. One solution could be to make this dependency optional,
> however I would prefer to move all postgres-related code to provider
> or some other, more appropriate place.
> 
> Bye
> Martin
> 
> On 10/23/07, godofredo contreras <frdcn at hotmail.com> wrote:
> >
> > Hi:
> >
> > This change was to add the ability to create mysql, oracle and postgres
> > vector layers
> > via ogr provider, the other changes were in the "add postgis layer dialog"
> > that now
> > support different kinds of connections in addition to postgres. The new
> > classes in
> > core/dbutilities are used to separate connection management from the dialogs
> > and
> > that will be used to update SPIT to work with  mysql, and oracle.
> >
> > There are some plans to support layer creation, and Tim suggested to work a
> > little
> > with QgsVectorWriter to support some kind of export functionality, but I
> > think this will
> > be until second stage (once ogr spatial database layer creation and spit
> > will be working ).
> >
> > Regars
> >
> > Godofredo Contreras
> >

_________________________________________________________________
Windows Live Hotmail and Microsoft Office Outlook – together at last.  Get it now.
http://office.microsoft.com/en-us/outlook/HA102225181033.aspx?pid=CL100626971033
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.osgeo.org/pipermail/qgis-developer/attachments/20071107/bcf1253e/attachment.html