[Qgis-developer] Python support in project file
Nathan Woodrow
madmanwoo at gmail.com
Tue Aug 21 14:34:07 PDT 2012
Those changes look good Larry.
- Nathan
On Wed, Aug 22, 2012 at 5:58 AM, Larry Shaffer <larrys at dakotacarto.com> wrote:
> Hi,
>
>
> On Tuesday, August 21, 2012, Giuseppe Sucameli wrote:
>>
>> Hi Nathan,
>>
>> On Tue, Aug 21, 2012 at 10:22 AM, Nathan Woodrow <madmanwoo at gmail.com>
>> wrote:
>> > - There seems to be a margin around the map canvas now. That wasn't
>> > there before.
>>
>> ok, I see it now :)
>>
>> > - If there are no marcos in the project file I wouldn't show the
>> > warning bar.
>>
>> When the checkbox is unchecked it doesn't show the warning bar,
>> I'll also check if the textbox is empty.
>>
>> > - Might be good to have a "more info" hyperlink so that people can
>> > understand what it really means
>>
>> A link to the help page, sure it's a good thing.
>>
>> > - Would be nice if we can to have a Enable Always button with a drop
>> > down menu with "Always for all projects" and "Always for just this
>> > project" (don't have it popup a dialog asking if they are sure just
>> > save it they can always change it after)
>>
>> Even if I don't like the enable always option as it might cause
>> security issues, I thought to put just one checkbox in the setting
>> dialog to make macros always enabled.
>>
>> I don't imagine how to make the "always enable macros
>> for just this project" option working.
>> Projects don't have a identifier like layers and I guess the path is
>> not a good choice because the project file could be replaced
>> and the user could easily be wrong.
>
>
> Really nice addition. I have a couple of suggestions.
>
> Whether the warning appears seems to be keyed off of the recent opened files
> listing. Since that evetually will cause the user to see the warning again
> (once their project is removed from that listing), would it be better to
> keep a listing of projects (at least by file name, not path) in the app
> settings that have been allowed to run macros? Possibly in addition to the
> recently opened check?
>
>>
>> What do you think?
>>
>> > - Might need to make the icon have a transparent icon background :)
>>
>> The icon is the one used for the message logger (displayed
>> bottom-right when in Debug mode), of course that white
>> background has to be removed. We also need a icon for
>> the close button (x) and icons for the other 2 levels of
>> messages, i.e. critical and information.
>
>
> For a cleaner look for the message bar, I created two svg icons output to
> png, one for the warning and one for close [0]. Also, the Enable action is
> more of a link. Basically, removing the tool button backgrounds via a
> stylesheet and having the cursor change as expected for web page links
> allows for the focus of the bar to be the message, not the button actions.
>
> [0] http://dl.dropbox.com/u/4058089/qgis/message-bar.png
>
>> Opinions are welcome!
>
>
> The order of QgsMessageBar instance being created comes before the theme
> (soon to be deprecated anyway?) is set.
>
> The changes I have suggested are available as an addition to your branch
> uploaded to my github repository [1].
>
> [1]
> https://github.com/dakcarto/Quantum-GIS/commit/5a1500cc6e0d8a8965d17884e107bb3e22b77182
>
> T
>
>
>>
>> Regards.
>>
>> > - Nathan
>> >
>> >
>> > On Tue, Aug 21, 2012 at 5:54 PM, Nathan Woodrow <madmanwoo at gmail.com>
>> > wrote:
>> >> Very nice Giiseppe. Will test soon.
>> >>
>> >> Sent from some fancy phone looking thingo
>> >> From: Giuseppe Sucameli
>> >> Sent: 21/08/2012 5:24 PM
>> >> To: qgis-developer ML
>> >> Subject: Re: [Qgis-developer] Python support in project file
>> >> Hi all,
>> >>
>> >> I've pushed the code on the branch project_macros on my
>> >> QGis fork [1].
>> >>
>> >> The macros python code is loaded into a dummy module,
>> >> in this manner it can be unloaded when needed.
>> >>
>> >> On Thu, May 31, 2012 at 8:30 AM, Martin Dobias <wonder.sk at gmail.com>
>> >> wrote:
>> >>> On Thu, May 31, 2012 at 2:49 AM, Giuseppe Sucameli
>> >>> <sucameli at faunalia.it> wrote:
>> >>>> I would save it into the project (embedded in the XML) until we will
>> >>>> have a different way to pack project and related stuff together.
>> >>>
>> >>> Ok - hopefully XML will not choke python indentation :)
>> >>
>> >> It seems conversion to XML doesn't break anything.
>> >>
>> >>>> BTW one popup only would be needed, i.e. the project is loaded.
>> >>>> If the user trust macros then they become active and ready to be
>> >>>> executed.
>> >>>
>> >>> See Nathan's post - he better explains what I have meant.
>> >>
>> >> I developed a QgsMessageBar class to display information
>> >> to the user using a non-blocking widget.
>> >>
>> >> The bar allows to push more messages as in a queue, then
>> >> displays them one by one beside to a close button.
>> >> The button remove the current message or the bar when the
>> >> message queue is empty.
>> >>
>> >> The QgisApp instance creates a object of that class and
>> >> puts it above the canvas and also on the top of it (so the canvas
>> >> is not refreshed when the bar is shown or hidden as no resize
>> >> event occurs).
>> >>
>> >> Please, could you test it and report here?
>> >>
>> >> Regards.
>> >>
>> >> --
>> >> Giuseppe Sucameli - Faunalia
>> >> _______________________________________________
>> >> Qgis-developer mailing list
>> >> Qgis-developer at lists.osgeo.org
>> >> http://lists.osgeo.org/mailman/listinfo/qgis-developer
>> > _______________________________________________
>> > Qgis-developer mailing list
>> > Qgis-developer at lists.osgeo.org
>> > http://lists.osgeo.org/mailman/listinfo/qgis-developer
>>
>>
>>
>> --
>> Giuseppe Sucameli - Faunalia
>> _______________________________________________
>> Qgis-developer mailing list
>> Qgis-developer at lists.osgeo.org
>> http://lists.osgeo.org/mailman/listinfo/qgis-developer
>
>
>
> --
>
> Larry Shaffer
> Dakota Cartography
> Black Hills, South Dakota
More information about the Qgis-developer
mailing list