[Qgis-developer] Delimited text plugin and file encoding dialog - advice please!

Tim Sutton lists at linfiniti.com
Sat Apr 27 15:20:38 PDT 2013


On Sat, Apr 27, 2013 at 9:56 PM, Chris Crook <ccrook at linz.govt.nz> wrote:
> Hi
> The new delimited text plugin GUI has a selector for file encoding which I added (to support different file encodings!).
> However I've just noticed that there is a QgsEncodingFileDialog which already supports selecting encoding for a file (though it is not much used in QGIS).
> It would make sense to use this for the delimited text plugin, but that would make the provider dependent on the gui library, rather than just the core library.  So I'm just wondering if that is considered "A Bad Thing".  And whether using the QgsEncodingFileDialog would keep the plugin more consistent with the rest of QGIS, and so would be A Good Thing?

Making the provider dependent on GUI lib would be bad IMHO.  Probably
one could split the UI and the provider itself so that the add delim
layer ui is in he gui lib.



> Thanks
> Chris
> This message contains information, which is confidential and may be subject to legal privilege. If you are not the intended recipient, you must not peruse, use, disseminate, distribute or copy this message. If you have received this message in error, please notify us immediately (Phone 0800 665 463 or info at linz.govt.nz) and destroy the original message. LINZ accepts no responsibility for changes to this email, or for any attachments, after its transmission from LINZ. Thank You.
> _______________________________________________
> Qgis-developer mailing list
> Qgis-developer at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/qgis-developer

Tim Sutton - QGIS Project Steering Committee Member (Release  Manager)
Please do not email me off-list with technical
support questions. Using the lists will gain
more exposure for your issues and the knowledge
surrounding your issue will be shared with all.

Visit http://linfiniti.com to find out about:
 * QGIS programming and support services
 * Mapserver and PostGIS based hosting plans
 * FOSS Consulting Services
Skype: timlinux
Irc: timlinux on #qgis at freenode.net

More information about the Qgis-developer mailing list