[Qgis-developer] Please stop spamming commit logs!

[Larry Shaffer]

Hi Alessandro,

On Fri, Oct 10, 2014 at 6:57 AM, Alessandro Pasotti <apasotti at gmail.com>
wrote:

> 2014-10-10 14:44 GMT+02:00 Jürgen E. <jef at norbit.de>:
> > Hi Matthias,
> >
> > On Fri, 10. Oct 2014 at 11:53:28 +0200, Matthias Kuhn wrote:
> >> To make an example, this is a good commit message.
> >>
> >>
> https://github.com/qgis/QGIS/commit/a132bc9a9e318c2321c8fba13dc9503b4d11e2aa
> >>
> >> It states
> >>  * which problem it solves
> >>  * and what it does exactly
> >>
> >> And I could not care less about an additional line at the bottom stating
> >> "Funded by John Wayne"
> >
> > Almost.  It should have "Fixes #8166" in it to automatically link to the
> issue
> > and close it - Bugfix #8166 doesn't create that link.
> >
>
> Good hints. If it's not already in CODING, we could add these
> guidelines in that file.
>
> Also, since most of you don't seem to be annoyed by the "funded by"
> sentences, I  think we can agree on Victor's proposal: if the new
> feature/bug fix etc. was funded by an organization, a company or an
> individual, a single line (80 chars max) sentence can be added as the
> last line of the commit, after a blank line.
>
> That line should be added only in the last "merge" (final) commit and
> not on all and every individual commit.
>

I disagree. "Funded by" attribution lines should go wherever the author
feels is appropriate, regardless of whether the commit is a merge type,
pulling in a whole branch, or the commits are simply rebased on top of
master.

It is a matter of public record:

* QGIS is a public project
* The funding is for a public project.
* The funding is a matter of public record (unless otherwise deemed by
sponsor).
* The commit log is a public record (and the longest standing one for the
project).

I fail to see how any of that can be misconstrued as "spam," if the line in
a commit is merely an attribution, i.e. not part of the first line of the
commit.

Even if *every* single commit message in the QGIS repo had a "Funded by"
attribution line, I could not see how that is anything but a matter of
fact. Actually, I think that would be an awesome record of the project's
prowess of finding sponsorship.

Regards,

Larry Shaffer
Dakota Cartography
Black Hills, South Dakota


>
> --
> Alessandro Pasotti
> w3:   www.itopen.it
> _______________________________________________
> Qgis-developer mailing list
> Qgis-developer at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/qgis-developer
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/qgis-developer/attachments/20141010/10c0e10b/attachment.html>