[QGIS-Developer] More errors from OS X 10.13 compiling

[Etienne Trimaille]

The patch has been added this week according to git blame (maybe a
copy/paste)
In the QT issue tracker, they said the issue has been fixed in Qt 5.4.1
only https://bugreports.qt.io/browse/QTBUG-40449 so we might keep this code.

I made a PR already in QGIS: https://github.com/qgis/QGIS/pull/5822

2017-12-07 16:40 GMT+01:00 Vincent Habchi <vince at macports.org>:

> Hey guys,
>
> I’m not sure this has been brought up yet, so here it is:
>
> The fix #11399 doesn’t seem to work on OS X 10.13 anymore or needs further
> patching:
>
> qgslayoutdesignerdialog.cpp:948:11: error: use of undeclared identifier
> 'kCFAllocatorDefault'
>          kCFAllocatorDefault,
>          ^
> qgslayoutdesignerdialog.cpp:950:11: error: use of undeclared identifier
> 'kCFStringEncodingUTF8'
>          kCFStringEncodingUTF8
>          ^
> qgslayoutdesignerdialog.cpp:954:11: error: use of undeclared identifier
> 'kCFAllocatorDefault'
>          kCFAllocatorDefault,
>          ^
> qgslayoutdesignerdialog.cpp:956:11: error: use of undeclared identifier
> 'kCFURLPOSIXPathStyle'
>          kCFURLPOSIXPathStyle,
>          ^
> qgslayoutdesignerdialog.cpp:962:11: error: use of undeclared identifier
> 'kCFAllocatorDefault'
>          kCFAllocatorDefault,
>          ^
> qgslayoutdesignerdialog.cpp:968:22: error: unknown type name 'CFIndex'
>        static const CFIndex maxAbsPathCStrBufLen = 4096;
>                     ^
> qgslayoutdesignerdialog.cpp:973:33: error: unknown type name 'UInt8'
>               reinterpret_cast<UInt8 *>( &absPathCStr[0] ),
>                                ^
> qgslayoutdesignerdialog.cpp:980:7: error: use of undeclared identifier
> 'CFRelease'
>      CFRelease( relCFURL );
>      ^
>
> Also I get this error, in the same file, later:
>
> qgslayoutdesignerdialog.cpp:1263:3: error: use of undeclared identifier
> 'mQgis'
>  mQgis->activateWindow();
>  ^
>
>
> If I disable these patches for MacOS (#if 0 …) the build works, of course.
> Since the first patch is supposed to target a Qt4 bug, can it be safely
> disabled when linking against Qt5?
>
> Thanks,
> Vincent
>
>
>
> _______________________________________________
> QGIS-Developer mailing list
> QGIS-Developer at lists.osgeo.org
> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/qgis-developer/attachments/20171207/2886bf99/attachment.html>