[QGIS-Developer] QGIS/OGR: FeatureIds reassigned on write to data provider?

[Even Rouault]

> I did some playing around and came up with some FeatureId mapping code
> which is pretty space efficient (basically requiring just
> 3*nDeletedFeatures entries), see below.
> 
> The code however assumes that the gaps in the fid-sequence are filled by
> decreasing the fids after the gap, which may be pretty specific to the
> OGR/Shapefile behaviour. 

This should clearly be restricted to Shapefiles. Other drivers don't have this compaction logic 
and will let happily holes in the feature ids.

> Hence in my view such code should really belong
> into the OGR provider (or perhaps even ogr itself) and not in the
> plugin. Thoughts?

Regarding putting that in OGR itself, there's no such API for that right now, and I'm not 
completely clear of the value to add one (specific use case, for a single driver)

Perhaps the QGIS OGR provider would be a better place for now.

Even

-- 
Spatialys - Geospatial professional services
http://www.spatialys.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/qgis-developer/attachments/20170710/138fa822/attachment.html>