[QGIS-Developer] Let (C)Make run sipify?

[Denis Rouzaud]

Thanks for the feedback.

Le jeu. 15 juin 2017 à 10:13, Sandro Santilli <strk at kbt.io> a écrit :

> On Thu, Jun 15, 2017 at 06:19:46AM +0000, Denis Rouzaud wrote:
>
> > To achieves this, I was thinking at letting cmake create the include sip
> > file lists (core.sip, gui.sip, …) to get a compile error whenever someone
> > adds a cpp header without its corresponding sip file. I gave it a try and
> > it works well.
>
> I think any file that can be automatically generated is ok to be built
> by running `make` (or whatever other build command cmake can produce).
> So rather than a compile error, you should get an automated build of
> the missing files.
>
> Likewise, generated files should not be in the GIT repository (as they
> are not things you want to edit manually).
>
> Is the above achievable ?
>

Yes this is totally achievable. That's the option 4, slightly modified.

I'm just not very keen on removing sip files from source at the moment, at
least until all files are sipified, but it should not be too long until
then.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/qgis-developer/attachments/20170615/c19b25ff/attachment-0001.html>