[QGIS-Developer] all provider keys lowercase

Richard Duivenvoorde rdmailings at duif.net
Mon Nov 27 07:30:44 PST 2017


Hi Devs,

after someone showing how to add a wms and wfs layer via PyQGIS, it
remembered again that the the provider key for wms is 'wms' and for wfs
it is 'WFS' (uppercase).

Is it an idea to homogenize this?
Grepping is see:

grep -ir "_key =" *

arcgisrest/qgsafsproviderextern.cpp:const QString AFS_KEY =
QStringLiteral( "arcgisfeatureserver" );
arcgisrest/qgsamsproviderextern.cpp:const QString AMS_KEY =
QStringLiteral( "arcgismapserver" );
db2/qgsdb2dataitems.cpp:static const QString PROVIDER_KEY =
QStringLiteral( "DB2" );
db2/qgsdb2provider.cpp:static const QString PROVIDER_KEY =
QStringLiteral( "DB2" );
delimitedtext/qgsdelimitedtextprovider.cpp:static const QString
TEXT_PROVIDER_KEY = QStringLiteral( "delimitedtext" );
gdal/qgsgdalprovider.cpp:static QString PROVIDER_KEY = QStringLiteral(
"gdal" );
gpx/qgsgpxprovider.cpp:const QString GPX_KEY = QStringLiteral( "gpx" );
grass/qgsgrassprovider.cpp:static QString GRASS_KEY = QStringLiteral(
"grass" );
mssql/qgsmssqlprovider.cpp:static const QString TEXT_PROVIDER_KEY =
QStringLiteral( "mssql" );
ogr/qgsogrprovider.cpp:static const QString TEXT_PROVIDER_KEY =
QStringLiteral( "ogr" );
oracle/qgsoracleprovider.cpp:const QString ORACLE_KEY = "oracle";
ows/qgsowsprovider.cpp:static QString PROVIDER_KEY = QStringLiteral(
"ows" );
postgres/qgspostgresprovider.cpp:const QString POSTGRES_KEY =
QStringLiteral( "postgres" );
spatialite/qgsspatialiteprovider.cpp:const QString SPATIALITE_KEY =
QStringLiteral( "spatialite" );
virtual/qgsvirtuallayerprovider.cpp:const QString VIRTUAL_LAYER_KEY =
QStringLiteral( "virtual" );
wcs/qgswcsprovider.cpp:static QString WCS_KEY = QStringLiteral( "wcs" );
wfs/qgswfsprovider.cpp:static const QString TEXT_PROVIDER_KEY =
QStringLiteral( "WFS" );
wms/qgswmsprovider.cpp:static QString WMS_KEY = QStringLiteral( "wms" );
wms/qgswmsprovider.cpp.unify_includes_modified.sortinc:static QString
WMS_KEY = QStringLiteral( "wms" );
wms/qgswmsprovider.cpp.9bfb3f31ee9c8085240eb6dc964726956e64fc26.prepare:static
QString WMS_KEY = QStringLiteral( "wms" );

So only DB2 and WFS are apparently to be changed...?

Thought this will only be beneficial to python devs though.

Too much?

Regards,

Richard


More information about the QGIS-Developer mailing list