[QGIS-Developer] Might snap change a 2D layer to 3D? discussion how to fix https://issues.qgis.org/issues/16927

[Luigi Pirelli]

Hi,

https://github.com/qgis/QGIS/pull/5223 has been merged in 2.18 HEAD
tnx to Mathias for review and Larry for merge. This will fix
[1][2][3].
Now it's time for a more extensive test. Givanni Manghi did already
extensive tests, but some side effects can escape!
The reason is that part of modified code is not covered by unit tests.
Btw, regarding the new controls I added, they are covered by unit
tests.

The main side effect can derive by the fact that any addFeature or
changeGeometry (during an editing session) were not checked for
successful termination. Now this check has been added and can modify
the consolidated workflow rising error during editing.

but why this new errors?
Now, depending on provider type, a geometry compatibility check is
done during editing process (e.g. using EditBuffer). If the new or
modified geometry is not compatible or it can't be adapted, then an
error is raised and notified in messageBar/log.
The good news is that, any compatibility error should be raised during
editing as it was in 2.14 LTR (this is a regression fix)

any regression or anomaly please file a new issue as usual.

Luigi Pirelli

[1] https://issues.qgis.org/issues/16927
[2] https://issues.qgis.org/issues/16948
[3] https://issues.qgis.org/issues/15741

**************************************************************************************************
* Boundless QGIS Support/Development: lpirelli AT boundlessgeo DOT com
* LinkedIn: https://www.linkedin.com/in/luigipirelli
* Stackexchange: http://gis.stackexchange.com/users/19667/luigi-pirelli
* GitHub: https://github.com/luipir
* Mastering QGIS 2nd Edition:
* https://www.packtpub.com/big-data-and-business-intelligence/mastering-qgis-second-edition
**************************************************************************************************


On 20 September 2017 at 16:49, Luigi Pirelli <luipir at gmail.com> wrote:
> The following PR should approach the above described issues:
>
> https://github.com/qgis/QGIS/pull/5223
>
> please give a try.
>
> respect the request to add a config option to force or not conversion
> I implemented the following rule:
> 1) as proposed by mathias... if there is only a conversion, do it!
> 2) if not conversion is possibile => raise error as soon as possibile
> during editing => it's up to the use to adapt the receiving layer to
> be compatible.
>
> regards
>
> Luigi Pirelli
>
> **************************************************************************************************
> * Boundless QGIS Support/Development: lpirelli AT boundlessgeo DOT com
> * LinkedIn: https://www.linkedin.com/in/luigipirelli
> * Stackexchange: http://gis.stackexchange.com/users/19667/luigi-pirelli
> * GitHub: https://github.com/luipir
> * Mastering QGIS 2nd Edition:
> * https://www.packtpub.com/big-data-and-business-intelligence/mastering-qgis-second-edition
> **************************************************************************************************
>
>
> On 8 September 2017 at 17:05, Luigi Pirelli <luipir at gmail.com> wrote:
>> On 8 September 2017 at 16:51, Matthias Kuhn <matthias at opengis.ch> wrote:
>>> I would try to avoid introducing the same logic in all tools like
>>> snapping, pasting, GPS digitizing, processing, ...
>>
>> I strongly agree
>>
>> Luigi Pirelli
>>
>> **************************************************************************************************
>> * Boundless QGIS Support/Development: lpirelli AT boundlessgeo DOT com
>> * LinkedIn: https://www.linkedin.com/in/luigipirelli
>> * Stackexchange: http://gis.stackexchange.com/users/19667/luigi-pirelli
>> * GitHub: https://github.com/luipir
>> * Mastering QGIS 2nd Edition:
>> * https://www.packtpub.com/big-data-and-business-intelligence/mastering-qgis-second-edition
>> **************************************************************************************************