[QGIS-Developer] Concerns re UX of new "duplicate features" actions in 2.99

[Matthias Kuhn]

Hi Dave, hi Nyall,

Thanks for all your thoughts and work on this. The approach that is
currently being developed sounds like a very reasonable one given the
remaining time for 3.0.


Another idea I had to handle things like this was an "activate
condition" for actions. The activate condition for the duplicate feature
action could be a simple `@layer_editable`.

The tricky thing is, that variables (or even expression functions) used
within such a construct will need to be notifiable (e.g. here upon layer
edit state change, but in theory it could depend on other things like
`selected_feature_count(@layer) > 2`), so the expression engine knows
when an expression needs to be re-evaluated.

It will be a non-trivial thing to do and I'm not yet convinced it's
worth it, but I could imagine that we find other areas in QGIS where
such an interactive machinery to enable button states or change labels
interactively based on expressions can come in handy.

Enjoy Madeira, I miss you all !!

Matthias


On 02/21/2018 03:55 PM, David Signer wrote:
> Hi Nyall
>
> I'll start with it today. So possibly it's done before the 23th.
>
> We could keep it as an Action, only enabled when the layer is editable.
> This would include an attribute of MapLayerAction, if it should be
> enabled only in editable mode or always (first case for the
> duplication-action). The user actions would need such a attribute as
> well. 
> Probably we could integrate this attribute as another scope-value, and
> use the scopes as well for the MapLayerActions.
> Then we need to decide on what scopes it should be displayed:
> - Canvas (in the main toolbar)
> - Layer (in the toolbar of attribute list)
> - Feature (in the actions of attribute form, right click on a feature
> in the form view, right click on the feature on canvas)
> - Field (right click on a field in row of attribute table, right click
> on field at identify result panel)
>
> What do you think?
>
> Thanks for the ini-configuration anyway. Probably we will need it as
> well. 
>
> Regards
> David
>
> /21 February 2018 05:27 Nyall Dawson <nyall.dawson at gmail.com> wrote:/
>
>     On 19 February 2018 at 16:24, Nyall Dawson wrote:
>     > On 15 February 2018 at 03:16, David Signer wrote:
>     >> Dear all
>     >>
>     >> I agree (and I guess everyone else does), that it's not okay
>     that this
>     >> feature is enabled when the layers are not in editable mode. I
>     already
>     >> started to fix that, but because of time I had to decide to
>     finish it next
>     >> week.
>     >>
>     >> Anyway, there is still the question, where it should appear.
>     IMHO it should
>     >> be everywhere, where you can add and delete features. If it's a
>     MapTool it
>     >> could be there as well, I think. I'll have to think about that.
>     >
>     > Thanks for your flexibility here!
>     >
>     > What's the chance of getting this resolved before 3.0 final? If we
>     > can't, can we please ifdef this out for 3.0 release and defer to
>     3.2?
>     >
>
>     In https://github.com/qgis/QGIS/pull/6399 I implement a advanced
>     settings option, "tools\showDuplicateFeatureActions" to control
>     whether these actions are shown. By default it's off, but interested
>     organisations can set the flag in their qgis_global_settings.ini to
>     show these actions.
>
>     I think that's a fair approach - it means that users/organisations
>     which require this feature can still use it in 3.0, whilst at the
>     same
>     time avoiding exposing the functionality to users by default until it
>     is refined.
>
>     Nyall
>
>
>
> ---------------------
>
> David Signer
>
> Programmer OPENGIS.CH
>
> Wülflingerstrasse 213
>
> CH - 8408  Winterthur
>
> + 41 (0) 78 766 13 03
>
> ---------------------
>
>
>
>
> _______________________________________________
> QGIS-Developer mailing list
> QGIS-Developer at lists.osgeo.org
> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/qgis-developer/attachments/20180221/39e774d7/attachment.html>