[QGIS-Developer] Processing options broken in QGIS LTR 2.18.19 (?)

[Nyall Dawson]

On 3 May 2018 at 16:49, Paolo Cavallini <cavallini at faunalia.it> wrote:
> Thanks Giovanni for checking. This kind of issues, in LTR minor
> releases, are particularly undesirable. We had already a few instances
> like this. Does anyone have ideas or suggestions on what we can do to
> prevent it?
> All the best.

It doesn't help 2.18, but unit tests are the fix here. At least in 3.0
the whole of processing core is totally soaked in unit tests.

I'm going to be submitting a grant proposal to start adding gui unit
tests to processing. That's now the most fragile part of the
processing framework.

Nyall

>
> Il 02/05/2018 22:11, Giovanni Manghi ha scritto:
>> this is the commit that apparently broke it
>>
>> https://github.com/qgis/QGIS/commit/c83261395476b62f67eace32c78460bdcfd79a8f
>>
>>
>> cheers
>>
>> -- G --
>>
>>
>>
>>
>>
>> On Wed, May 2, 2018 at 8:21 PM, Giovanni Manghi
>> <giovanni.manghi at gmail.com> wrote:
>>> Hi all,
>>> I just noticed the following (on both Ubuntu and Window):
>>>
>>> clicking "ok" in Processing options dialog generated a python error,
>>> then clicking on "close" generates another one and so on and the only
>>> thing left is killing the program. Does not seems to happen on
>>> 2.18.18.
>>>
>>> Anyone confirms? If confirmed any chance to make an new point release asap?
>>>
>>> thanks in advance
>>>
>>> -- G --
>>>
>>>
>>> error:
>>>
>>> Traceback (most recent call last):
>>>   File "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\gui\ProcessingToolbox.py",
>>> line 163, in updateProvider
>>>     item.refresh()
>>>   File "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\gui\ProcessingToolbox.py",
>>> line 377, in refresh
>>>     Processing.updateAlgsList()
>>>   File "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\core\Processing.py",
>>> line 184, in updateAlgsList
>>>     Processing.reloadProvider(p.getName())
>>>   File "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\core\Processing.py",
>>> line 189, in reloadProvider
>>>     algList.reloadProvider(providerName)
>>>   File "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\core\alglist.py",
>>> line 55, in reloadProvider
>>>     p.loadAlgorithms()
>>>   File "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\core\AlgorithmProvider.py",
>>> line 56, in loadAlgorithms
>>>     self._loadAlgorithms()
>>>   File "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\modeler\ModelerAlgorithmProvider.py",
>>> line 73, in _loadAlgorithms
>>>     folders = ModelerUtils.modelsFolders()
>>>   File "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\modeler\ModelerUtils.py",
>>> line 46, in modelsFolders
>>>     folder = ProcessingConfig.getSetting(ModelerUtils.MODELS_FOLDER)
>>>   File "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\core\ProcessingConfig.py",
>>> line 209, in getSetting
>>>     if name in ProcessingConfig.settings.keys():
>>> RuntimeError: maximum recursion depth exceeded in cmp
>> _______________________________________________
>> QGIS-Developer mailing list
>> QGIS-Developer at lists.osgeo.org
>> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
>> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
>>
>
>
> --
> Paolo Cavallini - www.faunalia.eu
> QGIS & PostGIS courses: http://www.faunalia.eu/training.html
> https://www.google.com/trends/explore?date=all&geo=IT&q=qgis,arcgis
> _______________________________________________
> QGIS-Developer mailing list
> QGIS-Developer at lists.osgeo.org
> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer