[QGIS-Developer] [Qgis-psc] Direct push forbidden to master

[Denis Rouzaud]

Le ven. 8 nov. 2019 à 09:33, ElPaso <elpaso at itopen.it> a écrit :

>
> I'm with Jürgen on this, I think we all are responsible developers
> acting for the good of QGIS and I didn't see any abuse on direct commits
> in the past few years.
>

While not strictly talking about abuse, there has been quite a few direct
push commits which broke the CI.
That generally meant looking at someone else work to fix things, sometimes
by several persons at the same time.
It also means all last PRs jobs that have to be restarted.
It gives a bad image/impression.
It's frustrating.

One saves himself about one hour time to see his work integrated in the
final branch.
All the good soldiers in the Travis queue are good for a restart.

In the history of breaking commits, it's always "small and insignificant
changes which won't affect the build or the CI". I made a few of these in
the past too.
Just because we don't have docker and clang installed in our brains ;)

What are the valid arguments to allow direct pushes?
I can see only one: the release process might requires this since it relies
on the branches themselves.
But this was clearly not the case in the last event.


> On the contrary, I think I should have committed to master directly to
> correct a PR of mines that I merged by mistake the day before 3.10
> release (https://github.com/qgis/QGIS/pull/32369) instead of waiting for
> an approval that didn't arrive in time (in this case it wasn't really a
> big problem though).


OK, this might be a valid reason: to fix merge errors.
But this really sounds like an edge case to me.
Anyway, this directly fit in the release process window I was mentioning
above, which might require a special treatment.

So this could be a proposition.
Enforce PRs in standard time but allow direct push by a list of safe
core-devs during the release process window.

Cheers,
Denis
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/qgis-developer/attachments/20191108/c6ca3e11/attachment-0001.html>