[QGIS-Developer] Missing Changelog Features

[Charles Dixon-Paver]

Typically the workflow is that most days I'll loop through any pull
requests labelled "feature" and see if they describe the new functionality
well enough to produce a changelog entry. This will usually be over the
review period before merging, so if there is something outstanding or
unclear I can ask the developer for more information/ screenshots etc
before the PR gets merged.

The Changelog label indicates that an item is "ready to harvest" and I
generally only apply it to *open* PRs with the feature label, then I
harvest the closed PRs with the Changelog label applied.

In your case it's a bit different though because I think between yourself
and Matheiu you might often be ready to merge before I even see the PR
(being the ninja-wizards I know you to be), so if you want to merge a
new feature before it's been tagged for changelog inclusion just add the
"Changelog" label yourself rather than letting the changelog workflow
become a blocker. Then I'll change the label to "ChangelogHarvested" once I
pull it into the changelog.qgis.org system.

I think it would get a bit messy having everyone trying to tag and label
these entries though, so I think we make this the exception for core
maintainers rather than the rule for most developers.

Alternatively I could periodically go through merged PRs with the feature
label that haven't been labelled with Changelog or Changelog harvested.
It's just an extra manual step (and point of failure), but I'm happy to
take that on rather than add extra work for the core devs, so let me know
if you would prefer that.

Fortunately the workflow has worked for the majority of new features
anyway, so we should still be ready to publish on release day!

Regards

On Tue, 13 Oct 2020 at 01:04, Nyall Dawson <nyall.dawson at gmail.com> wrote:

> On Mon, 12 Oct 2020 at 22:59, Charles Dixon-Paver <charles at kartoza.com>
> wrote:
>
> > @Nyall I noticed that you have introduced a lot of new features that
> jumped straight from PR=>merged without the changelog label.
>
> Sorry about this! I guess I'm a little confused by the responsibility
> here -- should we be tagging "Changelog" ourselves for anything which
> we deem as important to include in the changelog? Or is this a label
> which you want to reserve for your use only?
>
> >
> > With how hard and fast you introduce new contributions I think it would
> be folly for the changelog process to become a blocker for your work, so I
> don't particularly have an issue with this sidestepping of the "usual"
> process (PR=>feature label=>changelog label=>merge).
> >
> > You also typically provide detailed descriptions of the feature so
> that's not an issue for me, but if you could label your new features
> "Changelog" when you merge them so that I can include them as a part of the
> standard harvesting workflow I'd appreciate it.
> >
> > I tried to go collect all of those that are merged which you have tagged
> as "feature" for the next release and have added the following PRs to the
> changelog list:
> >
> > https://github.com/qgis/QGIS/pull/38316
> > https://github.com/qgis/QGIS/pull/38651
> > https://github.com/qgis/QGIS/pull/38652
> > https://github.com/qgis/QGIS/pull/38654
> > https://github.com/qgis/QGIS/pull/38624
> > https://github.com/qgis/QGIS/pull/37958
>
> I had a look, and think you've caught them all!
>
> Nyall
>
> >
> > If anyone has suggestions for improving the changelog maintenance
> workflow please let me know. It's documented on
> https://github.com/qgis/QGIS/wiki/Changelog-Workflows
> >
> > Regards
> >
> > --
> > Charles Dixon-Paver - GIS Specialist
> > Cell: +27(0)720607511
> >
> ------------------------------------------------------------------------------------------
> > Visit http://kartoza.com to find out about open source:
> > * Full stack web, desktop and mobile geospatial software development
> > * GIS training
> > * Support, hosting and maintenance
> > * Consulting services
> >
> -------------------------------------------------------------------------------------------
> > _______________________________________________
> > QGIS-Developer mailing list
> > QGIS-Developer at lists.osgeo.org
> > List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
> > Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/qgis-developer/attachments/20201013/7dfd301c/attachment.html>