[QGIS-Developer] Request for review before new release is cut

[Matthias Kuhn]

Hi

I do think 1 of them is a user facing issue. It had a test added a couple
of minutes ago, so it's coming in hot. It's approved now.

2 of the pull requests are in draft, so not ready for review.
The other 2 are not user facing bugs but improving handling of local test
execution, which I don't expect to improve the quality of the release.
Out of these 4 pull requests, 3 have been opened in the last 2 days.

1. Given the above, and also for the reasons already outlined by our
release manager Jürgen, I don't think a change in the release schedule is
justified.

2. It would be great to have a shorter pull request queue. I am not sure
however that lowering the bar to bring code into the codebase with fewer
eyes looking over it is a good approach. I would prefer to try to onboard
new people into this process and give incentives to actively take part in
the review process. Let me take the opportunity to thank Benoit for his
review. As a very active contributor in the QGIS project for 2 years
already, I think we could also consider promoting him to a QGIS core
committer. That would reward him for his efforts, but at the same time also
give more review power to QGIS and maybe motivate others to follow his lead.

Kind regards
Matthias

On Fri, Jun 21, 2024 at 11:15 AM Jürgen E. Fischer via QGIS-Developer <
qgis-developer at lists.osgeo.org> wrote:

> Hi Sandro,
>
> On Fri, 21. Jun 2024 at 10:22:14 +0200, Sandro Santilli wrote:
> > It's packaging time today but I still have 5 pull requests
> > pending approval reviews:
> >
> >   https://github.com/qgis/QGIS/pulls/strk
>
> As far as I can tell none of those are fixes for user facing bugs.
>
>
> > This mail is to present two requests:
> >
> >   1. To the release manager:
> >      Can to the release be postponed to give some
> >      time to reviewers to approve my pending PRs ?
>
> We release what's ready when it's time - unless something critical is
> spotted.
> I'd say those could well be merged and backported after the release.
>
>
> >   2. The the PSC:
> >      Can the policy be reviewed once again to find a
> >      better solution to this long-standing problem of
> >      growing PR queue (not being a bot that closes
> >      them after a while) ?
>
> Was that ever really discussed?   AFAIK it was put in place and nobody
> really
> objected, because it is generally a good thing.
>
> But at least my contributions have gone down a lot by the introduction of
> these
> hurdles (ie. mandatory PRs, delays by CI tests and reviews and even - or
> mainly? -
> the improved stability of master, because stuff now breaks in PRs and
> doesn't
> hit the nightlies of master, where I'd fix them) as it multiplies the
> effort
> required for each of them (many mostly small ones).
>
>
> Jürgen
>
> --
> Jürgen E. Fischer
> Dipl.-Inf. (FH)           norBIT GmbH               Tel. +49-4931-918175-31
> Software Engineer         Rheinstraße 13            Fax. +49-4931-918175-50
> Geschäftsführer           D-26506 Norden
> https://www.norbit.de
> _______________________________________________
> QGIS-Developer mailing list
> QGIS-Developer at lists.osgeo.org
> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/qgis-developer/attachments/20240621/01200bb3/attachment.htm>