[QGIS-Developer] Remove "Polygons must follow boundaries of layer ..." check in Geometry checker plugin?

[Régis Haubourg]

ok then. I understood there was something berried in the old geometry 
checker code , but thought your question was about the new algorithm.
The question then is to refactor, fix and cleanup this old tool and 
susbequently the derived algorithms.
I would personnaly choose the deprecation way for this specifi 
algorithm. If it is buggy, and really hard to understand, I bet its real 
life usage is close to NULL.
Deprecating can be a lot easier than trying to fix it..
If someone feels in a mission to clean oldish and unused stuff, or 
willing to fund those little cleanups, while contracting for something 
bigger, please raise your hand!
Régis

On 12/16/25 09:36, DelazJ via QGIS-Developer wrote:
> Hi Régis (and devs),
> Thanks for your input.
> Just to clarify a point: it is not the algorithm the issue; it is the 
> original feature in the geometry checker that looks buggy (tm). The 
> algorithm (and this series of algorithms) "simply" ports the features 
> in the Geometry checker plugin to Processing, as is, allowing them to 
> be part of a workflow.
> Anyway, according to git blame, the "Polygons must follow boundaries" 
> check was introduced 8 years ago in 
> https://github.com/qgis/QGIS/commit/13725362977087dc1fd818e04cb8b2b82a635b98#diff-533309df511fcadcebbb577daeb4098209b97c3a6f7cb8146b38159c59f48f80R593 
> by Mani Sandro. The PR doesn't add much details on the feature and 
> there was almost no code review... Maybe does he (if still around) 
> remember what he tried to implement?
>
> Kind regards,
> Harrissou
>
> Le lun. 15 déc. 2025 à 21:39, Régis Haubourg via QGIS-Developer 
> <qgis-developer at lists.osgeo.org> a écrit :
>
>     Hi Harrissou,
>     I tried to understand the question and the history of the QEP and
>     PR discussions.
>     I think nobody can answer as long as such algorithm are so
>     difficult to understand.
>     They will indeed never be used in real life if users need to retro
>     engineer the algorithm, just like you did with Hefni.
>     Can I gently ask the developers originating this feature to make a
>     pedagogic effort towards our users, and in this effort save our
>     documentation team from such headaches?
>     If there is a real use case, please also use real life data to
>     illustrate it. Test samples with square and triangles are not
>     helping that much.
>     All the best
>     Régis
>
>     On 11/21/25 10:17, DelazJ via QGIS-Developer wrote:
>>     Hi devs,
>>     I didn't get any reply so I wonder if it is because nobody knows,
>>     nobody cares, or something else...
>>     Other than the concern of "adding/keeping a broken tool" in QGIS,
>>     we have a PR in the docs we don't really know how to finalize, so
>>     a feedback would be appreciated.
>>
>>     Thanks.
>>     Regards,
>>     Harrissou (for the docs team)
>>
>>     Le mar. 28 oct. 2025 à 10:38, DelazJ <delazj at gmail.com> a écrit :
>>
>>         Hi Devs,
>>         In the "Geometry checker" core plugin, there is that option
>>         called "Polygons must follow boundaries of layer ...", of
>>         which a Processing alg "Polygons exceeding boundaries" was
>>         recently created.
>>         While testing the algorithm in order to properly document it,
>>         we came across weird results (also output by the geometry
>>         checker) that we are unable to explain/understand their
>>         coherence.
>>
>>         Issues and discussion are availabel at
>>         https://github.com/qgis/QGIS/issues/63454 and
>>         https://github.com/qgis/QGIS-Documentation/pull/10314#issuecomment-3425649278
>>
>>         1/ Does anyone *KNOW* how this option is really supposed to
>>         check? and understand the logic behind the output?
>>         2/ If there is agreement that this tool does not adress any
>>         real use case, is it something we want to keep in QGIS (in
>>         this state)?
>>
>>         Looking forward to your replies.
>>         Regards,
>>         Harrissou
>>
>>
>>     _______________________________________________
>>     QGIS-Developer mailing list
>>     QGIS-Developer at lists.osgeo.org
>>     List info:https://lists.osgeo.org/mailman/listinfo/qgis-developer
>>     Unsubscribe:https://lists.osgeo.org/mailman/listinfo/qgis-developer
>
>
>     _______________________________________________
>     QGIS-Developer mailing list
>     QGIS-Developer at lists.osgeo.org
>     List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
>     Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
>
>
> _______________________________________________
> QGIS-Developer mailing list
> QGIS-Developer at lists.osgeo.org
> List info:https://lists.osgeo.org/mailman/listinfo/qgis-developer
> Unsubscribe:https://lists.osgeo.org/mailman/listinfo/qgis-developer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/qgis-developer/attachments/20251216/8e9c84ec/attachment.htm>