[geos-devel] PR for new GeometryFixer API

Even Rouault even.rouault at spatialys.com
Mon Apr 19 14:20:40 PDT 2021

Hi Paul,

no impact for GDAL test suite. It tests MakeValid() in a very light way 
(using mostly the "hourglass" looking invalid polygon)


Le 19/04/2021 à 22:44, Paul Ramsey a écrit :
> Important question for downstream maintainers: how wedded are you to 
> current 'makevalid' output? If you have tests of 'makevalid' right 
> now, and we replaced the default behaviour with the GeometryFixer, 
> you'd get different looking (valid) results.
> https://github.com/libgeos/geos/pull/433#issuecomment-821597724 
> <https://github.com/libgeos/geos/pull/433#issuecomment-821597724>
> However different looking, they are in many cases "more right" looking 
> (in some cases there's no obviously "right" answer, but in many there 
> are ones with more rightnesss). In general the processing in 
> geometryfixer should be faster too (fewer big overlay ops in total).
> But still: different. All those unit tests.
> What's your tradeoff?
> P
> On Fri, Apr 16, 2021 at 1:05 PM Martin Davis <mtnclimb at gmail.com 
> <mailto:mtnclimb at gmail.com>> wrote:
>     JTS recently had a class called GeometryFixer added.  The class
>     provides functionality to accept any invalid geometry and convert
>     it to a valid one.  This plugs a noticeable gap in the JTS API!
>     Paul R has ported this to GEOS:
>     https://github.com/libgeos/geos/pull/433
>     <https://github.com/libgeos/geos/pull/433>
>     It performs a similar function to the existing GEOS MakeValid
>     (which was a port of the PostGIS ST_MakeValid). But it has some
>     differences in semantics which are simpler and (hopefully) a
>     useful alternative.
>     See the PR for links to documentation of the functionality of
>     GeometryFixer (and there will be more docs and images coming soon).
>     Feedback is welcome, as always.
>     _______________________________________________
>     geos-devel mailing list
>     geos-devel at lists.osgeo.org <mailto:geos-devel at lists.osgeo.org>
>     https://lists.osgeo.org/mailman/listinfo/geos-devel
>     <https://lists.osgeo.org/mailman/listinfo/geos-devel>
> _______________________________________________
> geos-devel mailing list
> geos-devel at lists.osgeo.org
> https://lists.osgeo.org/mailman/listinfo/geos-devel

My software is free, but my time generally not.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/geos-devel/attachments/20210419/4b6af222/attachment.html>

More information about the geos-devel mailing list