[GRASS-dev] r.flow and G_message

[Brad Douglas]

I warned the list about this.

Here are the options:
- Go back to fprintf() statements
- Rewrite the code so they are properly formatted with G_message(), etc.
- Add another function simiar to G_message() that does not automatically
append '\n' (this has already been shot down).

On Thu, 2006-10-19 at 21:21 +0200, Jachym Cepicky wrote:
> hallo,
> 
> i do not know, how to solve fprints in r.flow. 
> 
> The module use it's own function to print messages (diag) 
> 
> When i removed this function and rewrite everything with help of
> G_message, the result is not well-arranged:
> 
> r.flow elevin=elevation.dem aspin=aspect barin=roads flout=tmp1
> lgout=tmp2 dsout=tmp3 --o
> Opening output files...
> WARNING: The vector 'tmp1' already exists and will be overwritten.
> Done
> Allocating memory: elevation
> aspect
> barrier
> density
> flowline header
> e/w distances
> quantization tolerances
> Reading input files: elevation...
> aspect
> barrier
> Precomputing: tangents
> e/w distances
> quantization tolerances
> re-oriented aspects
> Working...
> Done%
> Writing density file...
> Done
> Closing files...
> Building topology ...
> 0 primitives registered
> 0 areas built
> 0 isles built
> Attaching islands:
> Attaching centroids: Topology was built.
> Number of nodes     :   0
> Number of primitives:   0
> Number of points    :   0
> Number of lines     :   0
> Number of boundaries:   0
> Number of centroids :   0
> Number of areas     :   0
> Number of isles     :   0
> Done
> De-allocating memory...
> Done
> 
> What to do? Should I remove all informations about reading, precomputing
> and  allocating for each raster map? I suggest, that the most verbose
> output could look like this:
> 
> Opening output files...
> WARNING: The vector 'tmp1' already exists and will be overwritten.
> Allocating memory for maps
> Reading input files
> Precomputing
> Working
> Writing density file
> Closing files
> Building topology 
> 0 primitives registered
> 0 areas built
> 0 isles built
> Attaching islands:
> Attaching centroids: Topology was built.
> Number of nodes     :   0
> Number of primitives:   0
> Number of points    :   0
> Number of lines     :   0
> Number of boundaries:   0
> Number of centroids :   0
> Number of areas     :   0
> Number of isles     :   0
> Done
> De-allocating memory
> 
> what would you say?


-- 
Brad Douglas <rez touchofmadness com>                    KB8UYR/6
Address: 37.493,-121.924 / WGS84    National Map Corps #TNMC-3785