[postgis-tickets] [PostGIS] #4705: pgsql2shp - Pg field column in mapping file incorrectly compared with the name of the dbf field name
PostGIS
trac at osgeo.org
Thu Jun 18 23:40:16 PDT 2020
#4705: pgsql2shp - Pg field column in mapping file incorrectly compared with the
name of the dbf field name
----------------------------+-------------------
Reporter: zezzagio | Owner: robe
Type: defect | Status: new
Priority: medium | Milestone:
Component: loader/dumper | Version: 3.0.x
Resolution: | Keywords:
----------------------------+-------------------
Comment (by strk):
No need to create a pull request, your reference
to the URL of your git repository is enough.
Please for proper attribution use the correct author
for your commits though, with a valid email.
You can use, to amend your already made commit:
git commit --amend --author "Your Name <your at email>"
Then you'll need to force-push it to your remote, as this
would effectively be a change in history:
git push --force
Now, suggestions for the patch itself:
1. You don't need a SRID for the data (will just skip .prj creation)
2. You don't need a table, can use a query (can avoid -pre and -post)
3. I dubt you want to exit 0 (succes) when PostGIS object count test
fails
--
Ticket URL: <https://trac.osgeo.org/postgis/ticket/4705#comment:12>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.
More information about the postgis-tickets
mailing list